Home » Mailing list archives » linux-kernel » 2008 » February » 21

[PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Cyrill Gorcunov <gorcunov@...>
To: Ingo Molnar <mingo@...>, Thomas Gleixner <tglx@...>, H. Peter Anvin <hpa@...>
Cc: LKML <linux-kernel@...>
Subject: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code
Date: Thursday, February 21, 2008 - 3:50 pm

This patch replaces 4096 numeric constant with PAGE_SIZE macro.

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---

Text segments of old and new files *are* the same so
it wouldn't break current kernel.

 main.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


Index: linux-2.6.git/arch/x86/boot/main.c
===================================================================
--- linux-2.6.git.orig/arch/x86/boot/main.c	2008-02-09 22:27:13.000000000 +0300
+++ linux-2.6.git/arch/x86/boot/main.c	2008-02-21 22:28:10.000000000 +0300
@@ -14,6 +14,7 @@
  * Main module for the real-mode kernel code
  */
 
+#include <asm/page.h>
 #include "boot.h"
 
 struct boot_params boot_params __attribute__((aligned(16)));
@@ -36,7 +37,7 @@ static void copy_boot_params(void)
 	const struct old_cmdline * const oldcmd =
 		(const struct old_cmdline *)OLD_CL_ADDRESS;
 
-	BUILD_BUG_ON(sizeof boot_params != 4096);
+	BUILD_BUG_ON(sizeof boot_params != PAGE_SIZE);
 	memcpy(&boot_params.hdr, &hdr, sizeof hdr);
 
 	if (!boot_params.hdr.cmd_line_ptr &&
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] x86: cleanup - use PAGE_SIZE instead of numeric cons..., Cyrill Gorcunov, (Thu Feb 21, 3:50 pm)
Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ..., H. Peter Anvin, (Thu Feb 21, 3:52 pm)
Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ..., Cyrill Gorcunov, (Thu Feb 21, 3:56 pm)
Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ..., H. Peter Anvin, (Thu Feb 21, 3:59 pm)
Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ..., Cyrill Gorcunov, (Thu Feb 21, 4:00 pm)
Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric ..., H. Peter Anvin, (Thu Feb 21, 4:05 pm)