[PATCH] X86: remove WARN_ON if MTRRs are all blank

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Joerg Roedel
Date: Thursday, February 21, 2008 - 4:32 am

When running Linux inside KVM all MTRRs are blank because there is no reason to
set them up. So doing a WARN_ON if all MTRRs are blank is not necessary. It is
sufficient to print the warning message using printk.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 arch/x86/kernel/cpu/mtrr/main.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c
index b6e136f..e7f95a9 100644
--- a/arch/x86/kernel/cpu/mtrr/main.c
+++ b/arch/x86/kernel/cpu/mtrr/main.c
@@ -689,7 +689,6 @@ int __init mtrr_trim_uncached_memory(unsigned long end_pfn)
 	/* kvm/qemu doesn't have mtrr set right, don't trim them all */
 	if (!highest_pfn) {
 		printk(KERN_WARNING "WARNING: strange, CPU MTRRs all blank?\n");
-		WARN_ON(1);
 		return 0;
 	}
 
-- 
1.5.3.7



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] X86: remove WARN_ON if MTRRs are all blank, Joerg Roedel, (Thu Feb 21, 4:32 am)
Re: [PATCH] X86: remove WARN_ON if MTRRs are all blank, Ingo Molnar, (Thu Feb 21, 4:54 am)
Re: [PATCH] X86: remove WARN_ON if MTRRs are all blank, Joerg Roedel, (Thu Feb 21, 5:47 am)
Re: [PATCH] X86: remove WARN_ON if MTRRs are all blank, Ingo Molnar, (Thu Feb 21, 6:03 am)
Re: [PATCH] X86: remove WARN_ON if MTRRs are all blank, Joerg Roedel, (Thu Feb 21, 6:27 am)
Re: [PATCH 1/2] VMware guest detection for x86 and x86-64, Cristi Magherusan, (Wed Sep 24, 7:10 am)
Re: [PATCH 1/2] VMware guest detection for x86 and x86-64, H. Peter Anvin, (Wed Sep 24, 9:19 am)
Re: [PATCH 1/2] VMware guest detection for x86 and x86-64, H. Peter Anvin, (Wed Sep 24, 9:21 am)
Re: [PATCH 1/2] VMware guest detection for x86 and x86-64, Cristi Magherusan, (Wed Sep 24, 11:13 am)
Re: [PATCH 1/2] VMware guest detection for x86 and x86-64, H. Peter Anvin, (Wed Sep 24, 11:16 am)
Re: [PATCH 1/2] VMware guest detection for x86 and x86-64, H. Peter Anvin, (Wed Sep 24, 5:26 pm)
Re: [PATCH 1/2] VMware guest detection for x86 and x86-64, H. Peter Anvin, (Wed Sep 24, 5:37 pm)
Re: [PATCH 1/2] VMware guest detection for x86 and x86-64, Bernd Eckenfels, (Wed Sep 24, 6:28 pm)
Re: [PATCH 1/2] VMware guest detection for x86 and x86-64, H. Peter Anvin, (Wed Sep 24, 9:54 pm)
Re: [PATCH 1/2] VMware detection support for x86 and x86-64, H. Peter Anvin, (Wed Sep 24, 10:04 pm)
Re: [PATCH 1/2] VMware detection support for x86 and x86-64, H. Peter Anvin, (Wed Sep 24, 10:30 pm)
Re: [PATCH 1/2] VMware guest detection for x86 and x86-64, David Sanders, (Thu Sep 25, 2:56 am)
Re: [PATCH 1/2] VMware detection support for x86 and x86-64, Valdis.Kletnieks, (Fri Sep 26, 5:27 am)
Re: [PATCH 1/2] VMware detection support for x86 and x86-64, Valdis.Kletnieks, (Fri Sep 26, 6:22 am)
Re: [PATCH 1/2] VMware detection support for x86 and x86-64, H. Peter Anvin, (Fri Sep 26, 10:37 am)