login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
February
»
20
Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Jan Engelhardt
Subject:
Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot
Date: Wednesday, February 20, 2008 - 9:30 am
On Feb 20 2008 17:27, Patrick McHardy wrote:
quoted text
>> Striking. How can this even happen? A callsite which calls >> >> dev_alloc_skb(n) >> >> is just equivalent to >> >> __dev_alloc_skb(n, GFP_ATOMIC); >> >> which means there's like 4 (or 8 if it's long) bytes more on the >> stack. For a worst case, count in another 8 bytes for push and pop or mov on >> the stack. But that still does not add up to 23 kb. > > __dev_alloc_skb() is also an inline function which performs > some extra work. Which raises the question - if dev_alloc_skb() > is uninlined, shouldn't __dev_alloc_skb() be uninline as well? >
I'd like to see the results when {__dev_alloc_skb is externed and dev_alloc_skb remains inlined}. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[RFC PATCH 0/8]: uninline & uninline
, Ilpo Järvinen
, (Wed Feb 20, 6:47 am)
[RFC PATCH 1/8] [NET]: uninline skb_put, de-bloats a lot
, Ilpo Järvinen
, (Wed Feb 20, 6:47 am)
[RFC PATCH 2/8] [NET]: uninline skb_pull, de-bloats a lot
, Ilpo Järvinen
, (Wed Feb 20, 6:47 am)
[RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot
, Ilpo Järvinen
, (Wed Feb 20, 6:47 am)
[RFC PATCH 4/8] [NET]: uninline skb_push, de-bloats a lot
, Ilpo Järvinen
, (Wed Feb 20, 6:47 am)
[RFC PATCH 5/8] [NET]: uninline dst_release
, Ilpo Järvinen
, (Wed Feb 20, 6:47 am)
[RFC PATCH 6/8] [NET]: uninline skb_trim, de-bloats
, Ilpo Järvinen
, (Wed Feb 20, 6:47 am)
[RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf
, Ilpo Järvinen
, (Wed Feb 20, 6:47 am)
[RFC PATCH 8/8] Jhash in too big for inlining, move under lib/
, Ilpo Järvinen
, (Wed Feb 20, 6:47 am)
Re: [RFC PATCH 1/8] [NET]: uninline skb_put, de-bloats a lot
, Patrick McHardy
, (Wed Feb 20, 6:54 am)
Re: [RFC PATCH 1/8] [NET]: uninline skb_put, de-bloats a lot
, Eric Dumazet
, (Wed Feb 20, 6:57 am)
Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloa ...
, Jan Engelhardt
, (Wed Feb 20, 9:19 am)
Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloa ...
, Patrick McHardy
, (Wed Feb 20, 9:27 am)
Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloa ...
, Jan Engelhardt
, (Wed Feb 20, 9:30 am)
Re: [RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf
, Vlad Yasevich
, (Wed Feb 20, 3:16 pm)
Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloa ...
, Ilpo Järvinen
, (Wed Feb 20, 3:18 pm)
Re: [RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf
, Ilpo Järvinen
, (Wed Feb 20, 3:34 pm)
Re: [RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf
, Vlad Yasevich
, (Thu Feb 21, 8:27 am)
Re: [RFC PATCH 8/8] Jhash in too big for inlining, move un ...
, Andrew Morton
, (Sat Feb 23, 1:02 am)
Re: [RFC PATCH 0/8]: uninline & uninline
, Andrew Morton
, (Sat Feb 23, 1:02 am)
Re: [RFC PATCH 8/8] Jhash in too big for inlining, move un ...
, Ilpo Järvinen
, (Sat Feb 23, 3:05 am)
Re: [RFC PATCH 0/8]: uninline & uninline
, Ilpo Järvinen
, (Sat Feb 23, 3:11 am)
Re: [RFC PATCH 8/8] Jhash in too big for inlining, move un ...
, Andi Kleen
, (Sat Feb 23, 6:06 am)
Re: [RFC PATCH 0/8]: uninline & uninline
, Andi Kleen
, (Sat Feb 23, 6:15 am)
Re: [RFC PATCH 0/8]: uninline & uninline
, Ilpo Järvinen
, (Sat Feb 23, 11:06 am)
Re: [RFC PATCH 8/8] Jhash in too big for inlining, move un ...
, Andrew Morton
, (Sat Feb 23, 11:21 am)
Re: [RFC PATCH 0/8]: uninline & uninline
, Andrew Morton
, (Sat Feb 23, 11:55 am)
RE: [RFC PATCH 0/8]: uninline & uninline
, Hua Zhong
, (Sat Feb 23, 12:58 pm)
Re: [RFC PATCH 0/8]: uninline & uninline
, Andi Kleen
, (Sat Feb 23, 2:02 pm)
profile-likely patch (was Re: [RFC PATCH 0/8]: uninline & ...
, Valdis.Kletnieks
, (Wed Feb 27, 12:08 pm)
Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloa ...
, Ilpo Järvinen
, (Wed Mar 12, 8:27 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Christoph Lameter
[PATCH 1/2] Make page->private usable in compound pages V1
Luben Tuikov
Re: Integration of SCST in the mainstream Linux kernel
Alexey Dobriyan
Re: [2.6.22.2 review 09/84] Fix rfkill IRQ flags.
Michal Nazarewicz
Re: [PATCH] USB: Gadget: g_multi: added INF file for gadget with multiple configur...
Jesse Barnes
Re: PCI probing changes
git
:
Jakub Narebski
Re: GSoC 2008 - Mentors Wanted!
Jan Harkes
Re: git-svn and huge data and modifying the git-svn-HEAD branch directly
Andy Parkins
git-fetch fails with error code 128
Marcus Griep
Re: [PATCH 1/3] Git.pm: Add faculties to allow temp files to be cached
Junio C Hamano
Re: [JGIT PATCH 2/2] Decrease the fetch pack client buffer to the lower minimum
git-commits-head
:
Linux Kernel Mailing List
ARM: 5970/1: nomadik-gpio: fix spinlock usage
Linux Kernel Mailing List
sh-sci: update receive error handling for muxed irqs
Linux Kernel Mailing List
No need to do lock_super() for exclusion in generic_shutdown_super()
Linux Kernel Mailing List
x86, msr: Export the register-setting MSR functions via /dev/*/msr
Linux Kernel Mailing List
Input: gpio-keys - add support for disabling gpios through sysfs
linux-netdev
:
Eric Dumazet
[PATCH] net: ALIGN/PTR_ALIGN cleanup in alloc_netdev_mq()/netdev_priv()
Patrick McHardy
[NET_SCHED]: sch_ingress: remove netfilter support
Rose, Gregory V
RE: __bad_udelay in network driver breaks build
Patrick McHardy
Re: no reassembly for outgoing packets on RAW socket
Frans Pop
svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc
:
ropers
Re: Real men don't attack straw men
elitdostlar
Seks partneri arayan bayanlar bu adreste - 8878xs706x6438
Marcus Andree
Re: This is what Linus Torvalds calls openBSD crowd
Lars D. Noodén
Re: sshd.config and AllowUsers
Henning Brauer
Re: Sun Blade 1000?
Colocation donated by:
Syndicate