login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
February
»
20
Re: mm/slub.c: inconsequent NULL checking
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Pekka Enberg <penberg@...>
To: <bunk@...>, <clameter@...>, <penberg@...>, <mpm@...>
Cc: linux-mm@kvack.org <linux-mm@...>, linux-kernel@vger.kernel.org <linux-kernel@...>
Subject:
Re: mm/slub.c: inconsequent NULL checking
Date: Wednesday, February 20, 2008 - 9:52 am
Hi Adrian, On 2/20/2008, "Adrian Bunk" <bunk@kernel.org> wrote:
quoted text
> The Coverity checker spotted the following inconsequent NULL checking > introduced by commit 8ff12cfc009a2a38d87fa7058226fe197bb2696f: > > <-- snip --> > > ... > static inline int is_end(void *addr) > { > return (unsigned long)addr & PAGE_MAPPING_ANON; > } > ... > static void deactivate_slab(struct kmem_cache *s, struct kmem_cache_cpu *c) > { > ... > if (c->freelist) <---------------------------------------- > stat(c, DEACTIVATE_REMOTE_FREES);
I spotted this too. c->freelist should never be NULL so why not send a patch to Christoph? --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
mm/slub.c: inconsequent NULL checking
, Adrian Bunk
, (Tue Feb 19, 6:49 pm)
Re: mm/slub.c: inconsequent NULL checking
, Pekka Enberg
, (Wed Feb 20, 9:52 am)
[2.6 patch] mm/slub.c: remove unneeded NULL check
, Adrian Bunk
, (Fri Feb 22, 3:59 pm)
Re: [2.6 patch] mm/slub.c: remove unneeded NULL check
, Christoph Lameter
, (Wed Feb 27, 3:55 pm)
Re: [2.6 patch] mm/slub.c: remove unneeded NULL check
, Pekka Enberg
, (Fri Feb 22, 4:11 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg Kroah-Hartman
[PATCH 008/196] Chinese: add translation of volatile-considered-harmful.txt
Amit K. Arora
[RFC] Heads up on sys_fallocate()
Bart Van Assche
Integration of SCST in the mainstream Linux kernel
Linus Torvalds
Re: Slow DOWN, please!!!
git
:
linux-netdev
:
Gerrit Renker
[PATCH 0/37] dccp: Feature negotiation - last call for comments
David Miller
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller
[GIT]: Networking
Natalie Protasevich
[BUG] New Kernel Bugs
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
1 user
and
485 guests
online.
Online users
tanggana93
Syndicate