Re: [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Roland McGrath
Date: Tuesday, February 19, 2008 - 7:49 pm

> I spent some time read you mail carefully and dig into the code again.

It's not necessary for SA_ONSTACK to have "been cleared", by which I assume
you mean a sigaction call with SA_ONSTACK not set in sa_flags.  That is
indeed possible, but it's not the only case your patch broke.  It can just
be a different signal whose sigaction never had SA_ONSTACK, when you are
still on the signal stack from an earlier signal that did have SA_ONSTACK.


For 2 and 3, I would rather just wait until we unify signal.c anyway.


Thanks,
Roland
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 1/5] signal(x86_32): Improve the signal stack o ..., Valdis.Kletnieks, (Mon Feb 18, 11:05 am)
Re: [PATCH 1/5] signal(x86_32): Improve the signal stack o ..., Roland McGrath, (Tue Feb 19, 7:49 pm)