Home » Mailing list archives » linux-kernel » 2008 » February » 20

Re: [PATCH] do_signal_stop: use signal_group_exit()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Eric W. Biederman
Subject: Re: [PATCH] do_signal_stop: use signal_group_exit()
Date: Tuesday, February 19, 2008 - 7:32 pm

Oleg Nesterov <oleg@tv-sign.ru> writes:


Right.  Does anyone know what kind of audit was made of the tty code
to ensure everything would be fine?

It it was pretty thorough and it was just this little corner case
it makes sense to get the struct tty locking for pids correct.

Otherwise since the tty layer is historically not especially good
with it's locking. We should just revert the change above, and save
attacking this until someone has time to do a thorough review.

Eric
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] do_signal_stop: use signal_group_exit(), Oleg Nesterov, (Fri Feb 15, 11:02 am)
Re: [PATCH] do_signal_stop: use signal_group_exit(), Andrew Morton, (Fri Feb 15, 8:37 pm)
Re: [PATCH] do_signal_stop: use signal_group_exit(), Oleg Nesterov, (Sat Feb 16, 7:02 am)
[PATCH] free_pidmap: turn it into free_pidmap(struct upid *), Oleg Nesterov, (Sat Feb 16, 8:09 am)
Re: [PATCH] do_signal_stop: use signal_group_exit(), Oleg Nesterov, (Sun Feb 17, 4:10 pm)
Re: [PATCH] do_signal_stop: use signal_group_exit(), Eric W. Biederman, (Sun Feb 17, 9:11 pm)
Re: [PATCH] do_signal_stop: use signal_group_exit(), Valdis.Kletnieks, (Tue Feb 19, 4:39 pm)
Re: [PATCH] do_signal_stop: use signal_group_exit(), Eric W. Biederman, (Tue Feb 19, 7:32 pm)
[PATCH] (for -mm only) put_pid: make sure we don't free th ..., Oleg Nesterov, (Wed Feb 20, 9:14 am)
tty &amp;&amp; pid problems, Oleg Nesterov, (Wed Feb 20, 9:18 am)
Re: tty &amp;&amp; pid problems, Alan Cox, (Wed Feb 20, 9:19 am)
Re: tty &amp;&amp; pid problems, Oleg Nesterov, (Wed Feb 20, 9:28 am)
Re: tty &amp;&amp; pid problems, Jiri Slaby, (Wed Feb 20, 12:00 pm)
Re: tty &amp;&amp; pid problems, Eric W. Biederman, (Thu Feb 21, 6:39 pm)
Re: tty &amp;&amp; pid problems, Alan Cox, (Fri Feb 22, 2:37 am)