Home » Mailing list archives » linux-kernel » 2008 » February » 20

[patch] sysfs: small header file cleanup

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: David Rientjes
Subject: [patch] sysfs: small header file cleanup
Date: Tuesday, February 19, 2008 - 6:39 pm

Convert sysfs_remove_bin_file() to have a return type of 'void' for
!CONFIG_SYSFS configurations.  Also removes unnecessary colons from empty
void functions.

Cc: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: David Rientjes <rientjes@google.com>
---
 include/linux/sysfs.h |    9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -131,7 +131,6 @@ static inline int sysfs_create_dir(struct kobject *kobj)
 
 static inline void sysfs_remove_dir(struct kobject *kobj)
 {
-	;
 }
 
 static inline int sysfs_rename_dir(struct kobject *kobj, const char *new_name)
@@ -160,7 +159,6 @@ static inline int sysfs_chmod_file(struct kobject *kobj,
 static inline void sysfs_remove_file(struct kobject *kobj,
 				     const struct attribute *attr)
 {
-	;
 }
 
 static inline int sysfs_create_bin_file(struct kobject *kobj,
@@ -169,10 +167,9 @@ static inline int sysfs_create_bin_file(struct kobject *kobj,
 	return 0;
 }
 
-static inline int sysfs_remove_bin_file(struct kobject *kobj,
-					struct bin_attribute *attr)
+static inline void sysfs_remove_bin_file(struct kobject *kobj,
+					 struct bin_attribute *attr)
 {
-	return 0;
 }
 
 static inline int sysfs_create_link(struct kobject *kobj,
@@ -183,7 +180,6 @@ static inline int sysfs_create_link(struct kobject *kobj,
 
 static inline void sysfs_remove_link(struct kobject *kobj, const char *name)
 {
-	;
 }
 
 static inline int sysfs_create_group(struct kobject *kobj,
@@ -195,7 +191,6 @@ static inline int sysfs_create_group(struct kobject *kobj,
 static inline void sysfs_remove_group(struct kobject *kobj,
 				      const struct attribute_group *grp)
 {
-	;
 }
 
 static inline int sysfs_add_file_to_group(struct kobject *kobj,
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] documentation: fix firmware_sample_firmware_class ..., Randy Dunlap, (Mon Feb 18, 5:22 pm)
Re: [PATCH] documentation: fix firmware_sample_firmware_cl ..., David Rientjes, (Mon Feb 18, 5:32 pm)
Re: [PATCH] documentation: fix firmware_sample_firmware_cl ..., David Rientjes, (Mon Feb 18, 5:51 pm)
Re: [PATCH] documentation: fix firmware_sample_firmware_cl ..., Randy Dunlap, (Tue Feb 19, 3:40 pm)
[patch] sysfs: small header file cleanup, David Rientjes, (Tue Feb 19, 6:39 pm)
Re: [patch] sysfs: small header file cleanup, Randy Dunlap, (Tue Feb 19, 9:17 pm)
Re: [PATCH] documentation: fix firmware_sample_firmware_cl ..., Greg KH, (Tue Feb 19, 11:46 pm)
Re: [PATCH] documentation: fix firmware_sample_firmware_cl ..., Randy Dunlap, (Wed Feb 20, 1:10 pm)
Re: [PATCH] documentation: fix firmware_sample_firmware_cl ..., Greg KH, (Wed Feb 20, 1:40 pm)
[PATCH 1/2] firmware: move firmware_class from Documentati ..., Randy Dunlap, (Wed Feb 20, 2:20 pm)
Re: [PATCH 1/2] firmware: move firmware_class from Documen ..., Marcel Holtmann, (Wed Feb 20, 2:48 pm)
patch firmware-move-firmware_class-from-documentation-to-s ..., gregkh, (Wed Feb 20, 5:07 pm)