Re: USB OOPS 2.6.25-rc2-git1

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Brownell
Date: Tuesday, February 19, 2008 - 5:19 pm

On Tuesday 19 February 2008, David Miller wrote:

Please try that diagnostic patch I sent ... with CONFIG_USB_DEBUG.

Near as I can tell this is caused by some hardware oddity that needs
to be worked around.  We seem to be at stage where we've fixed some
problems, nudging code paths around so another one shows up, and have
incidentally had a new silicion-specific hardware erratum reported
in this area.  So more info is needed...

A quick anti-oops patch is appended, it should work OK on top of that
diagnostic patch, but won't necessarily resolve the underlying problem.

- Dave


--- g26.orig/drivers/usb/host/ehci-q.c	2008-02-19 16:15:04.000000000 -0800
+++ g26/drivers/usb/host/ehci-q.c	2008-02-19 16:15:59.000000000 -0800
@@ -993,6 +993,11 @@ static void end_unlink_async (struct ehc
 
 	iaa_watchdog_done(ehci);
 
+	if (!qh) {
+		WARN_ON(1);
+		return;
+	}
+
 	// qh->hw_next = cpu_to_hc32(qh->qh_dma);
 	qh->qh_state = QH_STATE_IDLE;
 	qh->qh_next.qh = NULL;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
USB OOPS 2.6.25-rc2-git1, Andre Tomt, (Tue Feb 19, 8:19 am)
Re: USB OOPS 2.6.25-rc2-git1, David Brownell, (Tue Feb 19, 11:49 am)
Re: USB OOPS 2.6.25-rc2-git1, Alan Stern, (Tue Feb 19, 12:31 pm)
Re: USB OOPS 2.6.25-rc2-git1, Andre Tomt, (Tue Feb 19, 2:58 pm)
Re: USB OOPS 2.6.25-rc2-git1, David Miller, (Tue Feb 19, 3:24 pm)
Re: USB OOPS 2.6.25-rc2-git1, Andre Tomt, (Tue Feb 19, 3:28 pm)
Re: USB OOPS 2.6.25-rc2-git1, Andre Tomt, (Tue Feb 19, 4:04 pm)
Re: USB OOPS 2.6.25-rc2-git1, David Brownell, (Tue Feb 19, 5:19 pm)
Re: USB OOPS 2.6.25-rc2-git1, David Brownell, (Tue Feb 19, 5:32 pm)
Re: USB OOPS 2.6.25-rc2-git1, David Miller, (Tue Feb 19, 6:40 pm)
Re: USB OOPS 2.6.25-rc2-git1, Alan Stern, (Wed Feb 20, 9:10 am)
Re: USB OOPS 2.6.25-rc2-git1, Andre Tomt, (Wed Feb 20, 1:33 pm)
Re: USB OOPS 2.6.25-rc2-git1, Alan Stern, (Wed Feb 20, 2:16 pm)
Re: USB OOPS 2.6.25-rc2-git1, David Brownell, (Wed Feb 20, 2:24 pm)
Re: USB OOPS 2.6.25-rc2-git1, David Brownell, (Wed Feb 20, 2:56 pm)
Re: USB OOPS 2.6.25-rc2-git1, Alan Stern, (Wed Feb 20, 3:33 pm)
Re: USB OOPS 2.6.25-rc2-git1, David Brownell, (Wed Feb 20, 3:54 pm)
Re: USB OOPS 2.6.25-rc2-git1, Andre Tomt, (Wed Feb 20, 5:25 pm)
Re: USB OOPS 2.6.25-rc2-git1, David Brownell, (Wed Feb 20, 5:53 pm)
Re: USB OOPS 2.6.25-rc2-git1, Alan Stern, (Thu Feb 21, 8:56 am)
Re: USB OOPS 2.6.25-rc2-git1, Alan Stern, (Thu Feb 21, 9:15 am)
Re: USB OOPS 2.6.25-rc2-git1, David Brownell, (Mon Feb 25, 2:13 am)
Re: USB OOPS 2.6.25-rc2-git1, David Brownell, (Tue Mar 4, 9:15 pm)
Re: USB OOPS 2.6.25-rc2-git1, Alan Stern, (Wed Mar 5, 10:04 am)
Re: USB OOPS 2.6.25-rc2-git1, David Brownell, (Wed Mar 5, 10:39 am)