Home » Mailing list archives » linux-kernel » 2008 » February » 2

Re: PCI: Remove users of pci_enable_device_bars()

Previous thread: [PATCH] PCI subsystem: AMD SATA IDE mode quirk by Cai, Crane on Saturday, February 2, 2008 - 1:56 am. (2 messages)

Next thread: [PATCH] add support for dynamic ticks and preempt rcu by Steven Rostedt on Saturday, February 2, 2008 - 2:26 am. (3 messages)
[view original message]
From: Jeff Garzik <jeff@...>
To: Linux Kernel Mailing List <linux-kernel@...>
Cc: Alan Cox <alan@...>, Benjamin Herrenschmidt <benh@...>, Greg Kroah-Hartman <gregkh@...>, Linux IDE mailing list <linux-ide@...>
Subject: Re: PCI: Remove users of pci_enable_device_bars()
Date: Saturday, February 2, 2008 - 2:27 am

So...  did the feedback mentioned in the commit log ever appear?  :)


	Jeff


--
[view original message]
From: Bartlomiej Zolnierkiewicz <bzolnier@...>
To: Jeff Garzik <jeff@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>, Alan Cox <alan@...>, Benjamin Herrenschmidt <benh@...>, Greg Kroah-Hartman <gregkh@...>, Linux IDE mailing list <linux-ide@...>
Subject: Re: PCI: Remove users of pci_enable_device_bars()
Date: Saturday, February 2, 2008 - 4:01 pm

Since Alan has commented on it:


http://lkml.org/lkml/2007/12/17/422


"5520 in fact is always enabled as it is the host bridge.

pci_enable_device_io will do just fine. The 5520 fun is if you disable it

the system hangs."


I moved on assuming that either submitter or integrator would follow up...

but it seems that it didn't happen. :(


PS Could somebody remove the stale comment from cs5520.c?


Thanks,

Bart

--
[view original message]
From: Greg KH <gregkh@...>
To: Bartlomiej Zolnierkiewicz <bzolnier@...>, Benjamin Herrenschmidt <benh@...>
Cc: Jeff Garzik <jeff@...>, Linux Kernel Mailing List <linux-kernel@...>, Alan Cox <alan@...>, Linux IDE mailing list <linux-ide@...>
Subject: Re: PCI: Remove users of pci_enable_device_bars()
Date: Saturday, February 2, 2008 - 4:05 pm

Ben, care to send me a patch for this, as it's your change?


thanks,


greg k-h

--
[view original message]
From: Benjamin Herrenschmidt <benh@...>
To: Greg KH <gregkh@...>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@...>, Jeff Garzik <jeff@...>, Linux Kernel Mailing List <linux-kernel@...>, Alan Cox <alan@...>, Linux IDE mailing list <linux-ide@...>
Subject: Re: PCI: Remove users of pci_enable_device_bars()
Date: Sunday, February 3, 2008 - 1:32 am

Ah sure, will do tomorrow.


Cheers,

Ben.


--
Previous thread: [PATCH] PCI subsystem: AMD SATA IDE mode quirk by Cai, Crane on Saturday, February 2, 2008 - 1:56 am. (2 messages)

Next thread: [PATCH] add support for dynamic ticks and preempt rcu by Steven Rostedt on Saturday, February 2, 2008 - 2:26 am. (3 messages)