Home » Mailing list archives » linux-kernel » 2008 » February » 2

[PATCH] [drivers/misc/asus-laptop.c] add parentheses

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roel Kluin <12o3l@...>
To: <corentincj@...>, <acpi4asus-user@...>
Cc: lkml <linux-kernel@...>
Subject: [PATCH] [drivers/misc/asus-laptop.c] add parentheses
Date: Saturday, February 2, 2008 - 4:07 pm

'!' has a higher priority than '&': bitanding has no effect.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c
index 7dce318..65c67d1 100644
--- a/drivers/misc/asus-laptop.c
+++ b/drivers/misc/asus-laptop.c
@@ -322,7 +322,7 @@ static void write_status(acpi_handle handle, int out, int mask)
 
 	switch (mask) {
 	case MLED_ON:
-		out = !out & 0x1;
+		out = !(out & 0x1);
 		break;
 	case GLED_ON:
 		out = (out & 0x1) + 1;

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] [drivers/misc/asus-laptop.c] add parentheses, Roel Kluin, (Sat Feb 2, 4:07 pm)
Re: [PATCH] [drivers/misc/asus-laptop.c] add parentheses, Len Brown, (Thu Feb 7, 1:42 am)