login
Header Space

 
 

Re: [patch] pci: pci_enable_device_bars() fix

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Greg KH <gregkh@...>, Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, <linux-pci@...>, <pcihpd-discuss@...>, linux-scsi <linux-scsi@...>
Date: Saturday, February 2, 2008 - 11:51 am

Ingo Molnar wrote:

Look at the line right above it...  AFAICS you want 
pci_enable_device_mem(), if the mask is selecting IORESOURCE_MEM BARs.

Also a CC to linux-scsi and the driver author would be nice, as they are 
the ones with hardware and can verify.

This set of changes seemed like 50% guesswork to me, without consulting 
the authors :(  And unlike many changes, you actually have to know the 
hardware [or get clues from surrounding code] to make the change.

	Jeff



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PATCH] PCI patches for 2.6.24, Greg KH, (Fri Feb 1, 7:11 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Sat Feb 2, 4:56 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Greg KH, (Sat Feb 2, 7:23 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Sat Feb 2, 11:51 am)
Re: [patch] pci: pci_enable_device_bars() fix, Ingo Molnar, (Sat Feb 2, 1:08 pm)
Re: [patch] pci: pci_enable_device_bars() fix, James Bottomley, (Sat Feb 2, 2:08 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Ingo Molnar, (Sat Feb 2, 3:00 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Sat Feb 2, 1:33 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Ingo Molnar, (Sat Feb 2, 1:57 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Sat Feb 2, 2:49 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Ingo Molnar, (Sat Feb 2, 3:35 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Sat Feb 2, 4:48 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Ingo Molnar, (Mon Feb 4, 8:57 am)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Mon Feb 4, 11:30 am)
Re: [patch] pci: pci_enable_device_bars() fix, Andrew Morton, (Mon Feb 4, 9:12 am)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Mon Feb 4, 11:32 am)
Re: [patch] pci: pci_enable_device_bars() fix, James Bottomley, (Sat Feb 2, 12:01 pm)
Re: [GIT PATCH] PCI patches for 2.6.24, Andrew Morton, (Fri Feb 1, 8:42 pm)
Re: [GIT PATCH] PCI patches for 2.6.24, Greg KH, (Fri Feb 1, 8:49 pm)
Re: [GIT PATCH] PCI patches for 2.6.24, Andrew Morton, (Fri Feb 1, 9:07 pm)
speck-geostationary