Re: [patch] pci: pci_enable_device_bars() fix

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jeff Garzik
Date: Saturday, February 2, 2008 - 8:51 am

Ingo Molnar wrote:

Look at the line right above it...  AFAICS you want 
pci_enable_device_mem(), if the mask is selecting IORESOURCE_MEM BARs.

Also a CC to linux-scsi and the driver author would be nice, as they are 
the ones with hardware and can verify.

This set of changes seemed like 50% guesswork to me, without consulting 
the authors :(  And unlike many changes, you actually have to know the 
hardware [or get clues from surrounding code] to make the change.

	Jeff



--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PATCH] PCI patches for 2.6.24, Greg KH, (Fri Feb 1, 4:11 pm)
Re: [GIT PATCH] PCI patches for 2.6.24, Andrew Morton, (Fri Feb 1, 5:42 pm)
Re: [GIT PATCH] PCI patches for 2.6.24, Greg KH, (Fri Feb 1, 5:49 pm)
Re: [GIT PATCH] PCI patches for 2.6.24, Andrew Morton, (Fri Feb 1, 6:07 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Sat Feb 2, 8:51 am)
Re: [patch] pci: pci_enable_device_bars() fix, James Bottomley, (Sat Feb 2, 9:01 am)
Re: [patch] pci: pci_enable_device_bars() fix, Ingo Molnar, (Sat Feb 2, 10:08 am)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Sat Feb 2, 10:33 am)
Re: [patch] pci: pci_enable_device_bars() fix, Ingo Molnar, (Sat Feb 2, 10:57 am)
Re: [patch] pci: pci_enable_device_bars() fix, James Bottomley, (Sat Feb 2, 11:08 am)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Sat Feb 2, 11:49 am)
Re: [patch] pci: pci_enable_device_bars() fix, Ingo Molnar, (Sat Feb 2, 12:00 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Ingo Molnar, (Sat Feb 2, 12:35 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Sat Feb 2, 1:48 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Sat Feb 2, 1:56 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Greg KH, (Sat Feb 2, 4:23 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Ingo Molnar, (Mon Feb 4, 5:57 am)
Re: [patch] pci: pci_enable_device_bars() fix, Andrew Morton, (Mon Feb 4, 6:12 am)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Mon Feb 4, 8:30 am)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Mon Feb 4, 8:32 am)