[patch] pci: pci_enable_device_bars() fix (was: [GIT PATCH] PCI patches for 2.6.24)

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Greg KH <gregkh@...>
Cc: Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>, <linux-kernel@...>, <linux-pci@...>, <pcihpd-discuss@...>
Date: Saturday, February 2, 2008 - 7:13 am

* Greg KH <gregkh@suse.de> wrote:


simple allyesconfig testing found a build failure due to last night's 
PCI merge, on 32-bit x86:

 drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_pci_probe_one':
 drivers/scsi/lpfc/lpfc_init.c:1897: error: implicit declaration of function 'pci_enable_device_bars'

fix attached.

( This call has been introduced upstream 3 weeks ago by commit 
  8a4df120b07, but the PCI tree has apparently not been fully re-tested
  with Linus-latest since that point. )

	Ingo

-------------->
Subject: pci: pci_enable_device_bars() fix
From: Ingo Molnar <mingo@elte.hu>

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/scsi/lpfc/lpfc_init.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/scsi/lpfc/lpfc_init.c
===================================================================
--- linux.orig/drivers/scsi/lpfc/lpfc_init.c
+++ linux/drivers/scsi/lpfc/lpfc_init.c
@@ -1894,7 +1894,7 @@ lpfc_pci_probe_one(struct pci_dev *pdev,
 	uint16_t iotag;
 	int bars = pci_select_bars(pdev, IORESOURCE_MEM);
 
-	if (pci_enable_device_bars(pdev, bars))
+	if (pci_enable_device_io(pdev))
 		goto out;
 	if (pci_request_selected_regions(pdev, bars, LPFC_DRIVER_NAME))
 		goto out_disable_device;
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PATCH] PCI patches for 2.6.24, Greg KH, (Fri Feb 1, 7:11 pm)
[patch] pci: pci_enable_device_bars() fix (was: [GIT PATCH] ..., Ingo Molnar, (Sat Feb 2, 7:13 am)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Sat Feb 2, 4:56 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Greg KH, (Sat Feb 2, 7:23 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Sat Feb 2, 11:51 am)
Re: [patch] pci: pci_enable_device_bars() fix, Ingo Molnar, (Sat Feb 2, 1:08 pm)
Re: [patch] pci: pci_enable_device_bars() fix, James Bottomley, (Sat Feb 2, 2:08 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Ingo Molnar, (Sat Feb 2, 3:00 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Sat Feb 2, 1:33 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Ingo Molnar, (Sat Feb 2, 1:57 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Sat Feb 2, 2:49 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Ingo Molnar, (Sat Feb 2, 3:35 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Sat Feb 2, 4:48 pm)
Re: [patch] pci: pci_enable_device_bars() fix, Ingo Molnar, (Mon Feb 4, 8:57 am)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Mon Feb 4, 11:30 am)
Re: [patch] pci: pci_enable_device_bars() fix, Andrew Morton, (Mon Feb 4, 9:12 am)
Re: [patch] pci: pci_enable_device_bars() fix, Jeff Garzik, (Mon Feb 4, 11:32 am)
Re: [patch] pci: pci_enable_device_bars() fix, James Bottomley, (Sat Feb 2, 12:01 pm)
Re: [GIT PATCH] PCI patches for 2.6.24, Andrew Morton, (Fri Feb 1, 8:42 pm)
Re: [GIT PATCH] PCI patches for 2.6.24, Greg KH, (Fri Feb 1, 8:49 pm)
Re: [GIT PATCH] PCI patches for 2.6.24, Andrew Morton, (Fri Feb 1, 9:07 pm)