[patch 25/27] chelsio: Fix skb->dev setting

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg KH
Date: Friday, February 1, 2008 - 5:21 pm

2.6.22-stable review patch.  If anyone has any objections, please let us
know.

------------------
From: Divy Le Ray <divy@chelsio.com>

patch 7de6af0f23b25df8da9719ecae1916b669d0b03d in mainline.

eth_type_trans() now sets skb->dev.
Access skb->def after it gets set.

Signed-off-by: Divy Le Ray <divy@chelsio.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/net/chelsio/sge.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/chelsio/sge.c
+++ b/drivers/net/chelsio/sge.c
@@ -1378,10 +1378,10 @@ static void sge_rx(struct sge *sge, stru
 	}
 	__skb_pull(skb, sizeof(*p));
 
-	skb->dev->last_rx = jiffies;
 	st = per_cpu_ptr(sge->port_stats[p->iff], smp_processor_id());
 
 	skb->protocol = eth_type_trans(skb, adapter->port[p->iff].dev);
+	skb->dev->last_rx = jiffies;
 	if ((adapter->flags & RX_CSUM_ENABLED) && p->csum == 0xffff &&
 	    skb->protocol == htons(ETH_P_IP) &&
 	    (skb->data[9] == IPPROTO_TCP || skb->data[9] == IPPROTO_UDP)) {

-- 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 00/27] 2.6.22-stable review, Greg KH, (Fri Feb 1, 5:19 pm)
[patch 01/27] X25: Add missing x25_neigh_put, Greg KH, (Fri Feb 1, 5:19 pm)
[patch 17/27] CASSINI: Fix endianness bug., Greg KH, (Fri Feb 1, 5:20 pm)
[patch 23/27] cxgb: fix T2 GSO, Greg KH, (Fri Feb 1, 5:21 pm)
[patch 24/27] cxgb: fix stats, Greg KH, (Fri Feb 1, 5:21 pm)
[patch 25/27] chelsio: Fix skb->dev setting, Greg KH, (Fri Feb 1, 5:21 pm)
Re: [patch 00/27] 2.6.22-stable review, Arkadiusz Miskiewicz, (Sat Feb 2, 11:55 am)
[patch 00/27] 2.6.22-stable review, Oliver Pinter (Pinté ..., (Mon Feb 4, 10:30 am)
Re: [patch 00/27] 2.6.22-stable review, Greg KH, (Mon Feb 4, 10:59 am)