Re: usb/serial/io_ti.c: inconsequent NULL checking

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Greg KH <gregkh@...>
Cc: Adrian Bunk <bunk@...>, Alan Cox <alan@...>, <linux-usb@...>, <linux-kernel@...>
Date: Tuesday, February 19, 2008 - 7:38 pm

On Feb 19, 2008 3:25 PM, Greg KH <gregkh@suse.de> wrote:

I think he meant inconsistent not "inconsequent."

Either the test of port->tty here is unneeded:

 if (port->tty)
               port->tty->low_latency = low_latency;

...or the lack of test of port->tty here is a mistake:

	 edge_set_termios (port, port->tty->termios);
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
usb/serial/io_ti.c: inconsequent NULL checking, Adrian Bunk, (Tue Feb 19, 6:49 pm)
Re: usb/serial/io_ti.c: inconsequent NULL checking, Ray Lee, (Tue Feb 19, 7:38 pm)