Home » Mailing list archives » linux-kernel » 2008 » February » 19

pnp_bus_resume(): inconsequent NULL checking

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Adrian Bunk
Subject: pnp_bus_resume(): inconsequent NULL checking
Date: Tuesday, February 19, 2008 - 3:49 pm

The Coverity checker spotted the following inconsequent NULL checking 
introduced by commit 5d38998ed15b31f524bde9a193d60150af30d916:

<--  snip  -->

...
static int pnp_bus_resume(struct device *dev)
{
...
        if (pnp_dev->protocol && pnp_dev->protocol->resume)
                pnp_dev->protocol->resume(pnp_dev);

        if (pnp_can_write(pnp_dev)) {
...

<--  snip  -->

pnp_can_write(pnp_dev) dereferences pnp_dev->protocol.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
pnp_bus_resume(): inconsequent NULL checking, Adrian Bunk, (Tue Feb 19, 3:49 pm)
Re: pnp_bus_resume(): inconsequent NULL checking, Rene Herman, (Tue Feb 19, 5:00 pm)
Re: pnp_bus_resume(): inconsequent NULL checking, Bjorn Helgaas, (Wed Feb 20, 9:59 am)
Re: pnp_bus_resume(): inconsequent NULL checking, Rene Herman, (Wed Feb 20, 10:47 pm)
Re: pnp_bus_resume(): inconsequent NULL checking, Bjorn Helgaas, (Thu Feb 21, 8:26 am)
Re: pnp_bus_resume(): inconsequent NULL checking, Adrian Bunk, (Thu Feb 21, 9:09 am)
Re: pnp_bus_resume(): inconsequent NULL checking, Rene Herman, (Thu Feb 21, 9:18 am)