login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
February
»
19
Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Ingo Molnar <mingo@...>
To: Ahmed S. Darwish <darwish.07@...>
Cc: Andrew Morton <akpm@...>, Ingo Molnar <mingo@...>, LKML <linux-kernel@...>
Subject:
Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code
Date: Tuesday, February 19, 2008 - 11:52 am
* Ahmed S. Darwish <darwish.07@gmail.com> wrote:
quoted text
> - local_irq_disable(); > - t->next = __get_cpu_var(tasklet_vec).list; > - __get_cpu_var(tasklet_vec).list = t; > - __raise_softirq_irqoff(TASKLET_SOFTIRQ); > - local_irq_enable(); > + /* We were not lucky enough to run, reschedule. */ > + __tasklet_schedule(t);
i think there's a subtle difference that you missed: this one does __raise_softirq_irqoff(), while __tasklet_schedule() does a raise_softirq_irqoff(). (note the lack of undescores) the reason is to avoid infinitely self-activating tasklets. Ingo --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule...
, Ahmed S. Darwish
, (Tue Feb 19, 11:37 am)
Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}sche...
, Ingo Molnar
, (Tue Feb 19, 11:52 am)
Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}sche...
, Ahmed S. Darwish
, (Tue Feb 19, 12:27 pm)
Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}sche...
, Ingo Molnar
, (Wed Feb 20, 6:41 am)
Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}sche...
, Ahmed S. Darwish
, (Wed Feb 20, 9:37 am)
Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}sche...
, Dmitry Adamushko
, (Wed Feb 20, 10:20 am)
Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}sche...
, Ahmed S. Darwish
, (Wed Feb 20, 3:39 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Alan
Re: [RFC] Heads up on sys_fallocate()
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman
[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Paul Mundt
Re: 2.6.22-rc4-mm2
git
:
openbsd-misc
:
linux-netdev
:
Gerrit Renker
[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller
Re: [GIT]: Networking
Frans Pop
svc: failed to register lockdv1 RPC service (errno 97).
Colocation donated by:
Who's online
There are currently
1 user
and
601 guests
online.
Online users
terytuk98
Syndicate