Home » Mailing list archives » linux-kernel » 2008 » February » 19

[BUG][RFC][GENERIC IRQ] linux-2.6.24 (delayed) disable IRQ feature not functional for handle_simple_irq

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Hennerich, Michael <Michael.Hennerich@...>
To: Thomas Gleixner <tglx@...>, Hennerich, Michael <Michael.Hennerich@...>
Cc: <mingo@...>, <linux-kernel@...>
Subject: [BUG][RFC][GENERIC IRQ] linux-2.6.24 (delayed) disable IRQ feature not functional for handle_simple_irq
Date: Tuesday, February 19, 2008 - 6:25 am

Thomas,

I have reasonable doubt that the delayed disable feature on linux-2.6.24 for handle_simple_irq is broken.

In 2.6.22 there was something like this:

	if (unlikely(!action || (desc->status & IRQ_DISABLED))) {
		if (desc->chip->mask)
			desc->chip->mask(irq);
...

However in 2.6.24 the "DISABLED" IRQ in case it happens is never going to be masked.  

	if (unlikely(!action || (desc->status & IRQ_DISABLED)))
		goto out_unlock;


I see a disabled IRQ being invoked in an endless loop.

-Michael

------------------------------------------------------------------
********* Analog Devices GmbH         michael.hennerich@analog.com
**  *****                                      Systems Engineering
**     ** Wilhelm-Wagenfeld-Strasse 6       
**  ***** D-80807 Munich                      
********* Germany                          
Registergericht München HRB 40368,  Geschäftsführer:  Thomas Wessel,  Vincent Roche,  Joseph E. McDonough 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[BUG][RFC] [GENERIC IRQ] irq_chip_set_defaults shutdown / di..., Hennerich, Michael, (Mon Feb 18, 12:58 pm)
Re: [BUG][RFC] [GENERIC IRQ] irq_chip_set_defaults shutdown ..., Thomas Gleixner, (Mon Feb 18, 1:49 pm)
RE: [BUG][RFC] [GENERIC IRQ] irq_chip_set_defaults shutdown ..., Hennerich, Michael, (Mon Feb 18, 2:04 pm)
RE: [BUG][RFC] [GENERIC IRQ] irq_chip_set_defaults shutdown ..., Thomas Gleixner, (Mon Feb 18, 4:47 pm)
[BUG][RFC][GENERIC IRQ] linux-2.6.24 (delayed) disable IRQ f..., Hennerich, Michael, (Tue Feb 19, 6:25 am)
Re: [BUG][RFC][GENERIC IRQ] linux-2.6.24 (delayed) disable I..., Thomas Gleixner, (Tue Feb 19, 6:49 am)
RE: [BUG][RFC][GENERIC IRQ] linux-2.6.24 (delayed) disable I..., Hennerich, Michael, (Tue Feb 19, 7:51 am)
Re: [BUG][RFC] [GENERIC IRQ] irq_chip_set_defaults shutdown ..., Thomas Gleixner, (Mon Feb 18, 4:37 pm)
RE: [BUG][RFC] [GENERIC IRQ] irq_chip_set_defaults shutdown ..., Hennerich, Michael, (Tue Feb 19, 4:58 am)
RE: [BUG][RFC] [GENERIC IRQ] irq_chip_set_defaults shutdown ..., Thomas Gleixner, (Tue Feb 19, 5:12 am)