Re: IO queueing and complete affinity w/ threads: Some results

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Alan D. Brunelle <Alan.Brunelle@...>
Cc: <linux-kernel@...>, <npiggin@...>, <dgc@...>, <arjan@...>
Date: Monday, February 18, 2008 - 8:37 am

On Thu, Feb 14 2008, Alan D. Brunelle wrote:

Alan, thanks for your very nice testing efforts on this! It's very
encouraging to see that the kthread based approach is even faster than
the softirq one, since the code is indeed much simpler and doesn't
require any arch modifications. So I'd agree that just testing the
kthread approach is the best way forward, and that scrapping the remote
softirq trigger stuff is sanest.

My main worry with the current code is the ->lock in the per-cpu
completion structure. If we do a lot of migrations to other CPUs, then
that cacheline will be bounced around. But we'll be dirtying the list of
that CPU structure anyway, so playing games to make that part lockless
is probably pretty pointless. So if you get around to testing on bigger
SMP boxes, it'd be interesting to look for. So far it looks like it's a
net win with more idle time, the benefit of keeping the rq completion
queue local must be out weighing the cost of diddling with the per-cpu
data.

-- 
Jens Axboe

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
IO queueing and complete affinity w/ threads: Some results, Alan D. Brunelle, (Mon Feb 11, 4:56 pm)
Re: IO queueing and complete affinity w/ threads: Some results, Alan D. Brunelle, (Thu Feb 14, 11:36 am)
Re: IO queueing and complete affinity w/ threads: Some results, Jens Axboe, (Mon Feb 18, 8:37 am)
Re: IO queueing and complete affinity w/ threads: Some results, Alan D. Brunelle, (Wed Feb 13, 11:35 am)