login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
February
»
18
Re: [PATCH] memcgroup: remove a useless VM_BUG_ON()
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
KAMEZAWA Hiroyuki <kamezawa.hiroyu@...>
To: Li Zefan <lizf@...>
Cc: <akpm@...>, <balbir@...>, <containers@...>, <linux-kernel@...>
Subject:
Re: [PATCH] memcgroup: remove a useless VM_BUG_ON()
Date: Monday, February 18, 2008 - 4:48 am
On Mon, 18 Feb 2008 15:34:48 +0800 Li Zefan <lizf@cn.fujitsu.com> wrote:
quoted text
> Remove this VM_BUG_ON(), as Balbir stated: > > We used to have a for loop with !list_empty() as a termination condition > and VM_BUG_ON(!pc) is a spill over. With the new loop, VM_BUG_ON(!pc) does not > make sense. > > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> > --- > mm/memcontrol.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 718acf8..631002d 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -534,7 +534,6 @@ unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan, > if (scan >= nr_to_scan) > break; > page = pc->page; > - VM_BUG_ON(!pc); > > if (unlikely(!PageLRU(page))) > continue; > -- > 1.5.4.rc3 >
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Thanks, -Kame --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()
, Li Zefan
, (Mon Feb 18, 1:59 am)
Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()
, YAMAMOTO Takashi
, (Mon Feb 18, 2:39 am)
Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()
, Balbir Singh
, (Mon Feb 18, 2:14 am)
Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()
, YAMAMOTO Takashi
, (Mon Feb 18, 2:22 am)
Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()
, Balbir Singh
, (Mon Feb 18, 2:20 am)
Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()
, Li Zefan
, (Mon Feb 18, 2:47 am)
Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()
, Balbir Singh
, (Mon Feb 18, 3:01 am)
[PATCH] memcgroup: remove a useless VM_BUG_ON()
, Li Zefan
, (Mon Feb 18, 3:34 am)
Re: [PATCH] memcgroup: remove a useless VM_BUG_ON()
, KAMEZAWA Hiroyuki
, (Mon Feb 18, 4:48 am)
Re: [PATCH] memcgroup: remove a useless VM_BUG_ON()
, Balbir Singh
, (Mon Feb 18, 4:12 am)
Re: [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON()
, Li Zefan
, (Mon Feb 18, 3:14 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Sunil Naidu
Re: Linux 2.6.20-rc6
Alan Cox
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Chris Snook
Re: init's children list is long and slows reaping children.
Greg Kroah-Hartman
[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
git
:
openbsd-misc
:
linux-netdev
:
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller
[GIT]: Networking
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Eric W. Biederman
Re: [PATCH 10/11] avoid kobject name conflict with different namespaces
Colocation donated by:
Who's online
There are currently
1 user
and
883 guests
online.
Online users
strcmp
Syndicate