Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Grant Grundler
Date: Sunday, February 17, 2008 - 8:21 pm

On Wed, Jan 30, 2008 at 09:23:06PM +0100, Ondrej Zary wrote:

The BUG_ON() is probably fine normally. But the media selection sounds broken.
It's possible to select the wrong media type with 21040 chip but shouldn't
be possible with 21041. For 21040 support, see de21040_get_media_info().
But de21041_get_srom_info() is expected to determine which media
types are supported from SEPROM "media blocks".   My guess is that code
is broken since it seems to work with de405 driver. If you care to
work the difference, I'd be happy to make a patch to fix that up.

Also, from code review, DE2104X driver still has a few places with
potential PCI MMIO Write posting issues.  Specifically, I was looking
in de_stop_hw() and de_set_media(). Several other bits of code correctly
flush MMIO writes: e.g. tulip_read_eeprom().



You'd have to basically hardcode only one media type and it's corresponding
parameters.


ISTR there was a time when tulip would compete with de4x5 for devices.
tulip is the preferred driver. That's clearly no longer the case
and perhaps both distro's need to revisit this.


de2104x is a "work in progress".
That's why it's marked "EXPERIMENTAL" in the Kconfig file.


No idea. I've only used tulip driver.

thanks for the bug report,
grant
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Ondrej Zary, (Sat Jan 26, 1:58 pm)
Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Ondrej Zary, (Wed Jan 30, 1:23 pm)
Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Grant Grundler, (Sun Feb 17, 8:21 pm)
Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Ondrej Zary, (Mon Feb 18, 9:40 am)
Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Grant Grundler, (Mon Feb 25, 12:15 am)
Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Jeff Garzik, (Mon Feb 25, 12:28 am)
Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Jeff Garzik, (Mon Feb 25, 12:30 am)
Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Ondrej Zary, (Mon Feb 25, 2:31 pm)
Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x, Grant Grundler, (Tue Feb 26, 12:48 am)