Home » Mailing list archives » linux-kernel » 2008 » February » 17

Re: [PATCH 1/3] x86: fix init_8259A() to not use outb_pic

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Alan Cox <alan@...>
To: David P. Reed <dpreed@...>
Cc: Thomas Gleixner <tglx@...>, Ingo Molnar <mingo@...>, H. Peter Anvin <hpa@...>, <linux-kernel@...>, David P. Reed <dpreed@...>
Subject: Re: [PATCH 1/3] x86: fix init_8259A() to not use outb_pic
Date: Sunday, February 17, 2008 - 6:25 pm

On Sun, 17 Feb 2008 16:56:28 -0500 (EST)
"David P. Reed" <dpreed@reed.com> wrote:


NAK

The entire point of inb_pic/outb_pic is to isolate the various methods
and keep the logic for delays in one place. Undoing this just creates a
nasty mess.

Quite probably inb_pic/outb_pic will end up as static inlines that do inb
or outb with a udelay of 1 or 2 but that is where the knowledge belongs.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/3] x86: fix init_8259A() to not use outb_pic, David P. Reed, (Sun Feb 17, 5:56 pm)
Re: [PATCH 1/3] x86: fix init_8259A() to not use outb_pic, Alan Cox, (Sun Feb 17, 6:25 pm)
Re: [PATCH 1/3] x86: fix init_8259A() to not use outb_pic, Rene Herman, (Sun Feb 17, 10:30 pm)
Re: [linux-kernel] Re: [PATCH 1/3] x86: fix init_8259A() to ..., David P. Reed, (Mon Feb 18, 12:05 am)
Re: [linux-kernel] Re: [PATCH 1/3] x86: fix init_8259A() to ..., Alan Cox, (Mon Feb 18, 6:37 am)