Home » Mailing list archives » linux-kernel » 2008 » February » 17

[PATCH 0/2] libata: implement 32-bit transfers for PIO mode

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Willy Tarreau <w@...>
To: <jeff@...>
Cc: <linux-ide@...>, <linux-kernel@...>
Subject: [PATCH 0/2] libata: implement 32-bit transfers for PIO mode
Date: Sunday, February 17, 2008 - 5:18 pm

Hi Jeff,

For several times I tried libata on small machines equipped with either
CompactFlash or IDE DOM (Disk-On-Module). All those machines with small
flashes (<= 256 MB) were about 35-40% slower under libata than under the
plain old IDE driver. I realized that all the slower ones were running
PIO only.

Today I had time to investigate the issue on a Geode LX board. At first
I thought it was the pata_cs5536 driver which would have incorrect timings,
but this was not the case. I finally noticed that under IDE, my flashes
were running in 32-bit mode while I could not enable 32-bit with libata.

Reading ata_data_xfer() made it obvious that transfers were only 16-bit
wide.

Thus, I have implemented the 32-bit mode to bring the performance back
to the level of the old IDE driver. I jumped from 1.5 MB/s to 2.5 MB/s,
which is an important difference at this level of performance, especially
when large files are read. The 32-bit mode is enabled using the ioctl
which is already implemented but only accepts a null value.

I'm joining two patches which I hope you'll consider for inclusion. I've
updated them to latest Linus' git.

Best regards,
Willy

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/2] libata: implement 32-bit transfers for PIO mode, Willy Tarreau, (Sun Feb 17, 5:18 pm)
Re: [PATCH 0/2] libata: implement 32-bit transfers for PIO m..., Alan Cox, (Sun Feb 17, 6:31 pm)
Re: [PATCH 0/2] libata: implement 32-bit transfers for PIO m..., Willy Tarreau, (Sun Feb 17, 7:08 pm)
[PATCH 2/2] libata: implement support for 32-bit PIO transfers, Willy Tarreau, (Sun Feb 17, 5:20 pm)
Re: [PATCH 2/2] libata: implement support for 32-bit PIO tra..., Alan Cox, (Sun Feb 17, 6:32 pm)
[PATCH 1/2] libata: implement ATA_IOC_GET_IO32/ATA_IOC_SET_I..., Willy Tarreau, (Sun Feb 17, 5:19 pm)
Re: [PATCH 1/2] libata: implement ATA_IOC_GET_IO32/ATA_IOC_S..., Jeff Garzik, (Thu Apr 17, 3:49 pm)
[PATCH] libata: implement support for 32-bit PIO transfers, Willy Tarreau, (Thu Apr 17, 6:02 pm)
Re: [PATCH 1/2] libata: implement ATA_IOC_GET_IO32/ATA_IOC_S..., Willy Tarreau, (Thu Apr 17, 3:46 pm)