[PATCH 15/27] cpufreq: fix section mismatch warnings

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: LKML <linux-kernel@...>, Andrew Morton <akpm@...>
Cc: Sam Ravnborg <sam@...>, Dave Jones <davej@...>
Date: Sunday, February 17, 2008 - 8:22 am

Fix the following warnings:
WARNING: vmlinux.o(.text+0xfe6711): Section mismatch in reference from the function cpufreq_unregister_driver() to the variable .cpuinit.data:cpufreq_cpu_notifier
WARNING: vmlinux.o(.text+0xfe68af): Section mismatch in reference from the function cpufreq_register_driver() to the variable .cpuinit.data:cpufreq_cpu_notifier
WARNING: vmlinux.o(.exit.text+0xc4fa): Section mismatch in reference from the function cpufreq_stats_exit() to the variable .cpuinit.data:cpufreq_stat_cpu_notifier

The warnings were casued by references to unregister_hotcpu_notifier()
from normal functions or exit functions.
This is flagged by modpost as a potential error because
it does not know that for the non HOTPLUG_CPU
scenario the unregister_hotcpu_notifier() is a nop.
Silence the warning by replacing the __initdata
annotation with a __refdata annotation.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Dave Jones <davej@codemonkey.org.uk>
---
 drivers/cpufreq/cpufreq.c       |    2 +-
 drivers/cpufreq/cpufreq_stats.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 64926aa..c45768a 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1783,7 +1783,7 @@ static int __cpuinit cpufreq_cpu_callback(struct notifier_block *nfb,
 	return NOTIFY_OK;
 }
 
-static struct notifier_block __cpuinitdata cpufreq_cpu_notifier =
+static struct notifier_block __refdata cpufreq_cpu_notifier =
 {
     .notifier_call = cpufreq_cpu_callback,
 };
diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
index 1b8312b..070421a 100644
--- a/drivers/cpufreq/cpufreq_stats.c
+++ b/drivers/cpufreq/cpufreq_stats.c
@@ -323,7 +323,7 @@ static int __cpuinit cpufreq_stat_cpu_callback(struct notifier_block *nfb,
 	return NOTIFY_OK;
 }
 
-static struct notifier_block cpufreq_stat_cpu_notifier __cpuinitdata =
+static struct notifier_block cpufreq_stat_cpu_notifier __refdata =
 {
 	.notifier_call = cpufreq_stat_cpu_callback,
 };
-- 
1.5.4.rc3.14.g44397

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/27] fix section mismatches, Sam Ravnborg, (Sun Feb 17, 8:12 am)
[PATCH 17/27] acer-wmi: fix section mismatch warnings, Sam Ravnborg, (Sun Feb 17, 8:22 am)
Re: [PATCH 17/27] acer-wmi: fix section mismatch warnings, Carlos Corbacho, (Sun Feb 17, 9:03 am)
Re: [PATCH 17/27] acer-wmi: fix section mismatch warnings, Sam Ravnborg, (Sun Feb 17, 11:05 am)
[PATCH 16/27] scsi: fix section mismatch in aic94xx, Sam Ravnborg, (Sun Feb 17, 8:22 am)
[PATCH 15/27] cpufreq: fix section mismatch warnings, Sam Ravnborg, (Sun Feb 17, 8:22 am)
[PATCH 24/27] pcmcia: annotate cb_alloc with __ref, Sam Ravnborg, (Sun Feb 17, 8:23 am)
[PATCH 14/27] hwmon: fix section mismatch in coretemp, Sam Ravnborg, (Sun Feb 17, 8:22 am)
Re: [PATCH 14/27] hwmon: fix section mismatch in coretemp, Mark M. Hoffman, (Sun Feb 17, 1:07 pm)
[PATCH 19/27] tpm: fix section mismatch warning, Sam Ravnborg, (Sun Feb 17, 8:22 am)