[PATCH 27/27] [ALSA] hdsp - fix section mismatch warnings

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: LKML <linux-kernel@...>, Andrew Morton <akpm@...>
Cc: Sam Ravnborg <sam@...>, Takashi Iwai <tiwai@...>, Jaroslav Kysela <perex@...>
Date: Sunday, February 17, 2008 - 8:23 am

Fix following warnings:
WARNING: sound/pci/rme9652/snd-hdsp.o(.text+0x34bc): Section mismatch in reference from the function hdsp_check_for_firmware() to the function .devinit.text:hdsp_request_fw_loader()
WARNING: sound/pci/rme9652/snd-hdsp.o(.text+0x4ac6): Section mismatch in reference from the function snd_hdsp_proc_read() to the function .devinit.text:hdsp_request_fw_loader()

Calling hdsp_request_fw_loader() were triggered from /proc
so this is not restricted to init or hotplug.
So removing the __devexit annotation of this function
and one of the functions fix the warning.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>
---
 sound/pci/rme9652/hdsp.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c
index c2bd438..6f07a25 100644
--- a/sound/pci/rme9652/hdsp.c
+++ b/sound/pci/rme9652/hdsp.c
@@ -745,7 +745,7 @@ static int hdsp_get_iobox_version (struct hdsp *hdsp)
 
 
 #ifdef HDSP_FW_LOADER
-static int __devinit hdsp_request_fw_loader(struct hdsp *hdsp);
+static int hdsp_request_fw_loader(struct hdsp *hdsp);
 #endif
 
 static int hdsp_check_for_firmware (struct hdsp *hdsp, int load_on_demand)
@@ -4688,7 +4688,7 @@ static struct snd_pcm_ops snd_hdsp_capture_ops = {
 	.copy =		snd_hdsp_capture_copy,
 };
 
-static int __devinit snd_hdsp_create_hwdep(struct snd_card *card,
+static int snd_hdsp_create_hwdep(struct snd_card *card,
 					   struct hdsp *hdsp)
 {
 	struct snd_hwdep *hw;
@@ -4857,7 +4857,7 @@ static int snd_hdsp_create_alsa_devices(struct snd_card *card, struct hdsp *hdsp
 
 #ifdef HDSP_FW_LOADER
 /* load firmware via hotplug fw loader */
-static int __devinit hdsp_request_fw_loader(struct hdsp *hdsp)
+static int hdsp_request_fw_loader(struct hdsp *hdsp)
 {
 	const char *fwfile;
 	const struct firmware *fw;
-- 
1.5.4.rc3.14.g44397

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/27] fix section mismatches, Sam Ravnborg, (Sun Feb 17, 8:12 am)
[PATCH 17/27] acer-wmi: fix section mismatch warnings, Sam Ravnborg, (Sun Feb 17, 8:22 am)
Re: [PATCH 17/27] acer-wmi: fix section mismatch warnings, Carlos Corbacho, (Sun Feb 17, 9:03 am)
Re: [PATCH 17/27] acer-wmi: fix section mismatch warnings, Sam Ravnborg, (Sun Feb 17, 11:05 am)
[PATCH 16/27] scsi: fix section mismatch in aic94xx, Sam Ravnborg, (Sun Feb 17, 8:22 am)
[PATCH 15/27] cpufreq: fix section mismatch warnings, Sam Ravnborg, (Sun Feb 17, 8:22 am)
[PATCH 27/27] [ALSA] hdsp - fix section mismatch warnings, Sam Ravnborg, (Sun Feb 17, 8:23 am)
[PATCH 24/27] pcmcia: annotate cb_alloc with __ref, Sam Ravnborg, (Sun Feb 17, 8:23 am)
[PATCH 14/27] hwmon: fix section mismatch in coretemp, Sam Ravnborg, (Sun Feb 17, 8:22 am)
Re: [PATCH 14/27] hwmon: fix section mismatch in coretemp, Mark M. Hoffman, (Sun Feb 17, 1:07 pm)
[PATCH 19/27] tpm: fix section mismatch warning, Sam Ravnborg, (Sun Feb 17, 8:22 am)