[PATCH 14/27] hwmon: fix section mismatch in coretemp

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: LKML <linux-kernel@...>, Andrew Morton <akpm@...>
Cc: Sam Ravnborg <sam@...>, Mark M. Hoffman <mhoffman@...>
Date: Sunday, February 17, 2008 - 8:22 am

Fix following warning:
WARNING: vmlinux.o(.text+0xebfd04): Section mismatch in reference from the function coretemp_cpu_callback() to the function .cpuinit.text:coretemp_device_add()

coretemp_cpu_callback() are only used inside a
HOTPLUG_CPU block so annotate it __cpuinit.
The notifier referencing the function are annotated
__refdata to silence warning from the exit function.
The unregister function do not use the embedded pointer
but clears the variable so the annotation is OK.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Mark M. Hoffman <mhoffman@lightlink.com>
---
 drivers/hwmon/coretemp.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index 3ee60d2..1439432 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -330,7 +330,7 @@ static void coretemp_device_remove(unsigned int cpu)
 	mutex_unlock(&pdev_list_mutex);
 }
 
-static int coretemp_cpu_callback(struct notifier_block *nfb,
+static int __cpuinit coretemp_cpu_callback(struct notifier_block *nfb,
 				 unsigned long action, void *hcpu)
 {
 	unsigned int cpu = (unsigned long) hcpu;
@@ -347,7 +347,7 @@ static int coretemp_cpu_callback(struct notifier_block *nfb,
 	return NOTIFY_OK;
 }
 
-static struct notifier_block coretemp_cpu_notifier = {
+static struct notifier_block coretemp_cpu_notifier __refdata = {
 	.notifier_call = coretemp_cpu_callback,
 };
 #endif				/* !CONFIG_HOTPLUG_CPU */
-- 
1.5.4.rc3.14.g44397

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/27] fix section mismatches, Sam Ravnborg, (Sun Feb 17, 8:12 am)
[PATCH 17/27] acer-wmi: fix section mismatch warnings, Sam Ravnborg, (Sun Feb 17, 8:22 am)
Re: [PATCH 17/27] acer-wmi: fix section mismatch warnings, Carlos Corbacho, (Sun Feb 17, 9:03 am)
Re: [PATCH 17/27] acer-wmi: fix section mismatch warnings, Sam Ravnborg, (Sun Feb 17, 11:05 am)
[PATCH 16/27] scsi: fix section mismatch in aic94xx, Sam Ravnborg, (Sun Feb 17, 8:22 am)
[PATCH 15/27] cpufreq: fix section mismatch warnings, Sam Ravnborg, (Sun Feb 17, 8:22 am)
[PATCH 24/27] pcmcia: annotate cb_alloc with __ref, Sam Ravnborg, (Sun Feb 17, 8:23 am)
[PATCH 14/27] hwmon: fix section mismatch in coretemp, Sam Ravnborg, (Sun Feb 17, 8:22 am)
Re: [PATCH 14/27] hwmon: fix section mismatch in coretemp, Mark M. Hoffman, (Sun Feb 17, 1:07 pm)
[PATCH 19/27] tpm: fix section mismatch warning, Sam Ravnborg, (Sun Feb 17, 8:22 am)