Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: H. Peter Anvin <hpa@...>

Cc: Roel Kluin <12o3l@...>, lkml <linux-kernel@...>

Subject: Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: replace !likely(x) by likely(!x)

Date: Sunday, February 17, 2008 - 12:16 am

On 17-02-08 04:56, H. Peter Anvin wrote:

quoted text> Rene Herman wrote:
>> On 16-02-08 20:01, H. Peter Anvin wrote:
>>> Roel Kluin wrote:
>>>> Not entirely sure who to send this to
>>>> ---
>>>> Replace !likely(x) by likely(!x)
>>>
>>> Whoa...
>>>
>>> Are you sure this is correct?
>>>
>>> !likely(x) is equivalent to unlikely(!x)
>>
>> Not with respect to its value I believe? likely(x) == !!(x), and 
>> unlikely(!x) == !!(!x) = !x, so conditions work out differently?
> 
> You missed one ! sign:
> 
> !likely(x) == !!!(x) == unlikely(!x) == !!(!(x))

Yup, sorry, misread.

Rene.
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: repl..., Roel Kluin, (Sat Feb 16, 11:58 am)

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: ..., H. Peter Anvin, (Sat Feb 16, 3:01 pm)

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: ..., Rene Herman, (Sat Feb 16, 10:33 pm)

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: ..., H. Peter Anvin, (Sat Feb 16, 11:56 pm)

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: ..., Rene Herman, (Sun Feb 17, 12:16 am)

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: ..., Roel Kluin, (Sat Feb 16, 3:29 pm)

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: ..., H. Peter Anvin, (Sat Feb 16, 3:31 pm)

Re: [PATCH 2/2] kernel/{exit.c, signal.c, power/process.c}: ..., Roel Kluin, (Sat Feb 16, 3:52 pm)


linux-kernel:
Hiten Pandya	Re: up? (emacs docbook xml ide)
Martin Michlmayr	Network slowdown due to CFS
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
git:

netbsd-tech-kern:
Christos Zoulas	Re: Boot device confusion
Manuel Bouyer	Re: NFSv3 bug
Anders Magnusson	Re: setsockopt() compat issue
Martin Husemann	Re: Compressed vnd handling tested successfully
openbsd-misc: