linux-kernel mailing list

FromSubjectsort iconDate
Andrey Borzenkov
[PATCH][2.6.25-rc2] Fix double lock in do_setlink introduced...
[ 58.097923] ============================================= [ 58.098883] [ INFO: possible recursive locking detected ] [ 58.099603] 2.6.25-rc2-1avb #1 [ 58.100013] --------------------------------------------- [ 58.100672] wpa_supplicant/2682 is trying to acquire lock: [ 58.100672] (dev_base_lock){-.--}, at: [<c0278697>] do_setlink+0x327/0x3 [ 58.100672] [ 58.100672] but task is already holding lock: [ 58.100672] (dev_base_lock){-.--}, at: [<c0278680>] do_setlink+0x310...
Feb 16, 7:57 pm 2008
Adrian McMenamin
[PATCH] maple: add driver for Sega Dreamcast controller
Add support for the SEGA Dreamcast controller as a joystick device. Based on Yaegashi Takeshi's old 2.4 driver (never in mainline) with the addition of functioning removal (and reinsertion) code. Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk> --- diff -ruN a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig --- a/drivers/input/joystick/Kconfig 2008-02-16 20:51:49.000000000 +0000 +++ b/drivers/input/joystick/Kconfig 2008-02-16 21:41:52.000000000 +0000 @@ -282,4 ...
Feb 16, 7:50 pm 2008
Rob Landley
Compiling with 2.6.25-rc2 with binutils 2.17 fails?
Is anybody else having trouble compiling the kernel with binutils 2.17? Still trying to track down why, but it works on a toolchain built from binutils 2.18 and gcc 4.1.3, but not with a toolchain from binutils 2.17 and gcc 4.1.2. And considering where it's failing... If binutils 2.18 is the only version that now builds the kernel, could we update Documentaiton/Changes to say that instead of 2.12? Rob -- "One of my most productive days was throwing away 1000 lines of code." - Ken Tho...
Feb 16, 7:27 pm 2008
Adrian McMenamin
[PATCH] maple: allow removal and reinsertion of keyboard dri...
Allow the removal (and subsequent reinsertion) of the maple_keyb (maple keyboard) driver by adding a working removal function. Also tidy long lines. Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk> --- diff -ruN a/drivers/input/keyboard/maple_keyb.c b/drivers/input/keyboard/maple_keyb.c --- a/drivers/input/keyboard/maple_keyb.c 2008-02-16 20:51:49.000000000 +0000 +++ b/drivers/input/keyboard/maple_keyb.c 2008-02-16 21:41:52.000000000 +0000 @@ -2,7 +2,7 @@ * SEGA Dreamca...
Feb 16, 7:43 pm 2008
Adrian McMenamin
[PATCH] maple: remove unused variable
Remove an unused variable from the definition of struct maple_device Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk> --- diff -ruN a/include/linux/maple.h b/include/linux/maple.h --- a/include/linux/maple.h 2008-02-16 20:52:09.000000000 +0000 +++ b/include/linux/maple.h 2008-02-16 21:42:06.000000000 +0000 @@ -64,7 +64,6 @@ int (*connect) (struct maple_device * dev); void (*disconnect) (struct maple_device * dev); struct device_driver drv; - int registered; }; -...
Feb 16, 7:37 pm 2008
Quel Qun
Re: Kernel oops with bluetooth usb dongle
-------------- Original message ---------------------- Hi, Thank you for the hand holding. I must admit I do not anything about kernel debugging. With or without nohz=off, the crashes are very similar. It looks like it fails to execute list_add_tail(&timer->entry, vec), line 294 of kernel/timer.c. I hope this helps, let me know if you need more info or want me to try anything else. -- Eric nohz=off list_add corruption. prev->next should be next (c047e704), but was 00000000. (p...
Feb 16, 5:37 pm 2008
Thomas Gleixner
Re: Kernel oops with bluetooth usb dongle
Unfortunately we only see that the list is corrupted but not which code caused it. This looks like something forgot to delete the timer before freeing the datastructure which contains it. Can you please enable CONFIG_SLUB_DEBUG=y and CONFIG_SLUB_DEBUG_ON=y and give it another try? If we can not catch it that way, I'll whip up a patch which points us to the code which added the offending timer. Thanks, tglx --
Feb 16, 7:59 pm 2008
Hans-Jürgen
What's needed for a PCIe card to be recognized?
I'm playing around with a vanilla 2.6.25-rc1, adding patches to make it work on an Asus EeePC. That one has the problem that its Mini PCIe WLAN module doesn't show up in lspci. That brought up a few questions that I couldn't answer yet: How can they "hide" a PCIe card? What could be their motive to do that? How can I make it appear? I found some solutions googling around, but they all seem to be funny workarounds, like unloading pciehp and then loading it again with pciehp_force=1, then switchi...
Feb 16, 5:59 pm 2008
Arjan van de Ven
Re: What's needed for a PCIe card to be recognized?
On Sat, 16 Feb 2008 22:59:32 +0100 go to the bios, enable the wireless card. that did it for me ;) -- If you want to reach me at my work email, use arjan@linux.intel.com For development, discussion and tips for power savings, visit http://www.lesswatts.org --
Feb 16, 6:39 pm 2008
Daniel Drake
pci-disable-decoding-during-sizing-of-bars.patch no longer n...
Hi, The patch titled pci-disable-decoding-during-sizing-of-bars.patch in -mm was previously used as a candidate to fix a boot hang with Intel's Q35 chipset: https://bugs.gentoo.org/show_bug.cgi?id=198810 However, that particular issue is solved by commit a0ca9909609 in Linus tree: PCI x86: always use conf1 to access config space below 256 bytes So unless there are other reasons for keeping pci-disable-decoding-during-sizing-of-bars around, I think we can drop it. Thanks, Daniel -- ...
Feb 16, 5:50 pm 2008
Andrew Morton Feb 16, 6:05 pm 2008
Matthew Wilcox
Re: pci-disable-decoding-during-sizing-of-bars.patch no long...
I agree it should be dropped. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." --
Feb 16, 6:00 pm 2008
Andreas Schwab
2.6.25-rc1/2 CD/DVD burning broken
Since commit aaa04c28cb9a1efd42541fdb7ab648231c2a2263 [blk_end_request: changing ide-cd (take 4)] I cannot burn any CD/DVD any more, getting the following error from wodim: Errno: 0 (Success), write_g1 scsi sendcmd: no error CDB: 2A 00 00 00 00 00 00 00 1F 00 status: 0x2 (CHECK CONDITION) Sense Bytes: 70 00 05 00 00 00 00 0E 00 00 00 00 21 02 00 00 Sense Key: 0x5 Illegal Request, Segment 0 Sense Code: 0x21 Qual 0x02 (invalid address for write) Fru 0x0 Sense flags: Blk 0 (not valid) resid: 6348...
Feb 16, 4:52 pm 2008
Jeff Garzik
[PATCH 00/14] [ISDN] convert HiSax to hotplug APIs
This is the next revision of the ISDN hotplug conversion patches. Changes since last version: - handled ml comments - checkpatch fixes - moved proto.h addition into correct changeset - separated some bug fixes out from the diva changeset, into their own changeset. Work remaining: - convert elsa - convert sedlbauer - test - address akpm's problem report? --
Feb 16, 12:41 am 2008
Jeff Garzik
[PATCH 01/14] [ISDN] HiSax: modularization prep
Pass a function pointer into the core HiSax probe function checkcard(), in order to facilitate modular drivers passing in their own setup routines. Signed-off-by: Jeff Garzik <jgarzik@redhat.com> --- drivers/isdn/hisax/config.c | 14 +++++++++----- drivers/isdn/hisax/hisax_cfg.h | 2 ++ 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/isdn/hisax/config.c b/drivers/isdn/hisax/config.c index a0ee43c..84d75a3 100644 --- a/drivers/isdn/hisax/config.c +++ b/dri...
Feb 16, 12:41 am 2008
Jeff Garzik
[PATCH 12/14] [ISDN] HiSax avm_pci, niccy: minor PNP fixes a...
Signed-off-by: Jeff Garzik <jgarzik@redhat.com> --- drivers/isdn/hisax/avm_pci.c | 9 ++++++--- drivers/isdn/hisax/niccy.c | 2 ++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/isdn/hisax/avm_pci.c b/drivers/isdn/hisax/avm_pci.c index 69f8389..0b420aa 100644 --- a/drivers/isdn/hisax/avm_pci.c +++ b/drivers/isdn/hisax/avm_pci.c @@ -781,8 +781,8 @@ static int __devinit avm_isa_setup(struct IsdnCard *card) struct IsdnCardState *cs = card->cs; /* old...
Feb 16, 3:17 pm 2008
Bartlomiej Zolnierki...
[PATCH 1/9] sgiioc4: use ide_find_port()
There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/pci/sgiioc4.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) Index: b/drivers/ide/pci/sgiioc4.c =================================================================== --- a/drivers/ide/pci/sgiioc4.c +++ b/drivers/ide/pci/sgiioc4.c @@ -591,20 +591,12 @@ sgiioc4_ide_setup_pci_device(struct pci_ unsigned long bar0, cmd_phys_base, ct...
Feb 16, 4:26 pm 2008
Bartlomiej Zolnierki...
[PATCH 9/9] ide: IDE_HFLAG_BOOTABLE -> IDE_HFLAG_NON_BOOTABLE
"bootable" should be the default behavior so replace IDE_HFLAG_BOOTABLE host flag with IDE_HFLAG_NON_BOOTABLE. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/pci/aec62xx.c | 3 ++- drivers/ide/pci/alim15x3.c | 1 - drivers/ide/pci/amd74xx.c | 3 +-- drivers/ide/pci/atiixp.c | 5 ++--- drivers/ide/pci/cmd64x.c | 9 ++++----- drivers/ide/pci/cs5520.c | 3 +...
Feb 16, 4:27 pm 2008
Bartlomiej Zolnierki...
[PATCH 8/9] qd65xx: return error value in qd_probe()
Return error value in qd_probe() and use it in qd65xx_init() instead of checking ide_hwifs[].chipset. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/legacy/qd65xx.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) Index: b/drivers/ide/legacy/qd65xx.c =================================================================== --- a/drivers/ide/legacy/qd65xx.c +++ b/drivers/ide/legacy/qd65xx.c @@ -396,7 +396,7 @@ static int __init ...
Feb 16, 4:27 pm 2008
Bartlomiej Zolnierki...
[PATCH 7/9] ht6560b: use driver name for resource allocation
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/legacy/ht6560b.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drivers/ide/legacy/ht6560b.c =================================================================== --- a/drivers/ide/legacy/ht6560b.c +++ b/drivers/ide/legacy/ht6560b.c @@ -32,6 +32,7 @@ * Try: http://www.maf.iki.fi/~maf/ht6560b/ */ +#define DRV_NAME "ht6560b" #define HT6560B_VERSION "v0.07" #include <linux/mod...
Feb 16, 4:27 pm 2008
Bartlomiej Zolnierki...
[PATCH 6/9] umc8672: don't use ide_hwifs[] in umc_set_pio_mo...
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/legacy/umc8672.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/ide/legacy/umc8672.c =================================================================== --- a/drivers/ide/legacy/umc8672.c +++ b/drivers/ide/legacy/umc8672.c @@ -105,13 +105,13 @@ static void umc_set_speeds (u8 speeds[]) static void umc_set_pio_mode(ide_drive_t *drive, const u8 pio) { + ide_hwif_t *hwif = drive-...
Feb 16, 4:27 pm 2008
Bartlomiej Zolnierki...
[PATCH 5/9] scc_pata: store 'hwif' pointer in struct scc_ports
Replace 'unsigned char hwif_id' by 'ide_hwif_t *hwif' in struct scc_ports. This allows us to remove ide_hwifs[] usage from scc_remove(). There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/pci/scc_pata.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: b/drivers/ide/pci/scc_pata.c =================================================================== --- a/drivers/ide/pci/scc_pata.c ...
Feb 16, 4:27 pm 2008
Bartlomiej Zolnierki...
[PATCH 4/9] cmd640: use ide_find_port()
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/pci/cmd640.c | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) Index: b/drivers/ide/pci/cmd640.c =================================================================== --- a/drivers/ide/pci/cmd640.c +++ b/drivers/ide/pci/cmd640.c @@ -744,20 +744,21 @@ static int __init cmd640x_init(void) printk(KERN_INFO "cmd640: buggy cmd640%c interface on %s, config=0x%02x" "\n", 'a' ...
Feb 16, 4:26 pm 2008
Bartlomiej Zolnierki...
[PATCH 3/9] cmd640: remove cmd_drives[]
* Pass 'ide_drive_t *drive' to check_prefetch(), set_prefetch_mode(), program_drive_counts() and cmd640_set_mode(). * Remove no longer needed cmd_drives[]. * Inline setup_device_ptrs() helper in cmd640x_init(). Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/pci/cmd640.c | 67 ++++++++++++++++++----------------------------- 1 file changed, 27 insertions(+), 40 deletions(-) Index: b/drivers/ide/pci/cmd640.c ============================================...
Feb 16, 4:26 pm 2008
Bartlomiej Zolnierki...
[PATCH 2/9] au1xxx-ide: use ide_find_port()
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/mips/au1xxx-ide.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) Index: b/drivers/ide/mips/au1xxx-ide.c =================================================================== --- a/drivers/ide/mips/au1xxx-ide.c +++ b/drivers/ide/mips/au1xxx-ide.c @@ -603,9 +603,11 @@ static int au_ide_probe(struct device *d goto out; } - /* FIXME: This might possibly break PCMCIA IDE devices */ - - hwi...
Feb 16, 4:26 pm 2008
Roel Kluin
[PATCH] fs/ufs/util.h 2nd parameter of fs32_to_cpu is not bo...
from: fs/befs/endian.h +33 static inline u32 fs32_to_cpu(const struct super_block *sb, fs32 n) { if (BEFS_SB(sb)->byte_order == BEFS_BYTESEX_LE) return le32_to_cpu((__force __le32)n); else return be32_to_cpu((__force __be32)n); } The 2nd parameter is not boolean --- Test the return value, rather than passing a boolean Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/fs/ufs/util.h b/fs/ufs/util.h index b26fc4d..23ceed8 1...
Feb 16, 3:38 pm 2008
Evgeniy Dushistov
Re: [PATCH] fs/ufs/util.h 2nd parameter of fs32_to_cpu is no...
Yeah, in origin patch, which introduced this code was the similar misprint. It is sad that after review only one was fixed, and the second go to mainline. Acked-by: Evgeniy Dushistov <dushistov@mail.ru> -- /Evgeniy --
Feb 16, 4:16 pm 2008
Erez Zadok
[PATCH -mmotm] fs/sysfs/file.c d_path fix
Using mmotm-2008-02-15-11-03, I get CC fs/sysfs/file.o fs/sysfs/file.c: In function 'sysfs_open_file': fs/sysfs/file.c:334: warning: passing argument 1 of 'd_path' from incompatible pointer type fs/sysfs/file.c:334: warning: passing argument 2 of 'd_path' from incompatible pointer type fs/sysfs/file.c:334: warning: passing argument 3 of 'd_path' makes integer from pointer without a cast fs/sysfs/file.c:334: error: too many arguments to function 'd_path' make[2]: *** [fs/sysfs/file.o] Error 1...
Feb 16, 3:12 pm 2008
Erez Zadok
[PATCH -mmotm] one more reject fix in arch/x86/Kconfig
Using mmotm-2008-02-15-11-03, I get $ make ARCH=i386 HOSTCC scripts/kconfig/conf.o HOSTCC scripts/kconfig/kxgettext.o HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf scripts/kconfig/conf -s arch/x86/Kconfig arch/x86/Kconfig:24: unknown option "HEAD" arch/x86/Kconfig:30: unknown option "FETCH_HEAD" make[2]: *** [silentoldconfig] Error 1 make[1]: *** [silentoldconfig] Error 2 make: *** No rule to make target `include/config/auto.conf', needed by `include/config/kernel.r...
Feb 16, 3:05 pm 2008
Byron Bradley
2.6.25-rc2-mm1: ARM build fail due to inflate-refactor-infla...
Commit 0ad34f5f5f12861d4a18542c1a26284023b07a8d produces the following build failure on ARM: CC arch/arm/boot/compressed/misc.o In file included from /home/bb3081/project/kernel/orion/arch/arm/boot/compressed/misc.c:242: /home/bb3081/project/kernel/orion/arch/arm/boot/compressed/../../../../lib/inflate.c: In function 'malloc': /home/bb3081/project/kernel/orion/arch/arm/boot/compressed/../../../../lib/inflate.c:255: error: 'free_mem_end_ptr' undeclared (first use in this function) /home/bb3081...
Feb 16, 2:58 pm 2008
Adrian McMenamin
Current git very broken on the Dreamcast
Will seek to bisect this, but I have just updated my sources to the latest git and it is not booting at all on the Dreamcast. With early printk on, I get nothing more than this before an instant reboot: [ 0.000000] Linux version 2.6.25-rc2-10953-g52065cd (adrian@bossclass) (gcc version 3.4.6) #511 PREEMPT Sat Feb 16 18:31:43 GMT 2008 [ 0.000000] console [sercon0] enabled [ 0.000000] Booting machvec: Sega Dreamcast --
Feb 16, 2:38 pm 2008
Adrian McMenamin
Re: Current git very broken on the Dreamcast
adrian@bossclass:~/gdrom-dev$ git bisect good e036eaa681a17f71b64f6d9040fe605555623919 is first bad commit commit e036eaa681a17f71b64f6d9040fe605555623919 Author: Magnus Damm <magnus.damm@gmail.com> Date: Thu Feb 14 13:52:43 2008 +0900 sh: use ctrl_in/out for on chip pci access This patch makes sure ctrl_inN/outN are used instead of inN/outN for on chip pci registers. Without this patch addresses may be adjusted using the value in generic_io_base. This patch m...
Feb 16, 3:48 pm 2008
Adrian McMenamin
Re: Current git very broken on the Dreamcast
Reverting this commit *will* let my Dreamcast boot - can it be rolled back pending further testing for a patch please? Adrian --
Feb 16, 3:59 pm 2008
Randy Dunlap
[PATCH] kernel-doc: fix function-pointer-parameter parsing
From: Richard Kennedy <richard@rsk.demon.co.uk> When running "make htmldocs" I'm seeing some non-fatal perl errors caused by trying to parse the callback function definitions in blk-core.c. The errors are "Use of uninitialized value in concatenation (.)..." in combination with: Warning(linux-2.6.25-rc2/block/blk-core.c:1877): No description found for parameter '' The function pointers are defined without a * i.e. int (drv_callback)(struct request *) The compiler is happy with them, b...
Feb 16, 1:43 pm 2008
Gunter Ohrner
vfat32 Free Cluster Count Update
Hi! Doesn't the Linux vfat driver update the FAT32's free cluster summary count? Zweiblum:~# dosfsck /dev/sda11 dosfsck 2.11, 12 Mar 2005, FAT32, LFN /dev/sda11: 2451 files, 28218/1918827 clusters Zweiblum:~# mount /dev/sda11 /mnt/win_daten/ Zweiblum:~# cp /etc/motd /mnt/win_daten/ Zweiblum:~# umount /mnt/win_daten/ Zweiblum:~# dosfsck /dev/sda11 dosfsck 2.11, 12 Mar 2005, FAT32, LFN Free cluster summary wrong (1890609 vs. really 1890608) 1) Correct 2) Don't correct ? ^C Zweiblum...
Feb 16, 1:43 pm 2008
Bartlomiej Zolnierki...
[PATCH 2/2] ide-pmac: use ide_find_port()
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/ppc/pmac.c | 44 +++++++++++++++++++------------------------- 1 file changed, 19 insertions(+), 25 deletions(-) Index: b/drivers/ide/ppc/pmac.c =================================================================== --- a/drivers/ide/ppc/pmac.c +++ b/drivers/ide/ppc/pmac.c @@ -1086,38 +1086,34 @@ pmac_ide_macio_attach(struct macio_dev * { void __iomem...
Feb 16, 1:54 pm 2008
Bartlomiej Zolnierki...
[PATCH 1/2] ide-pmac: dynamically allocate struct pmac_ide_h...
Dynamically allocate struct pmac_ide_hwif instances in pmac_ide_macio_attach() and pmac_ide_pci_attach(), then remove no longer needed pmac_ide[]. Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/ppc/pmac.c | 49 +++++++++++++++++++++++++++++++++---------------- 1 file changed, 33 insertions(+), 16 deletions(-) Index: b/drivers/ide/ppc/pmac.c =========================================================...
Feb 16, 1:53 pm 2008
Gunter Ohrner
Understanding Block Device Behaviour
Hi! Maybe someone on this list can shed some light on my following observations. I have a machine running Linux (2.6.23 / 2.6.24) as its main OS, a Windows XP test installation on a physical primary partition and one logical drive formatted as VFAT32 for exchanging data (/dev/sda11 / "d:"). I'm running the Windows inside QEMU/KVM, using "-hda /dev/sda" to provide my physical disk to the VM. Of course, sda11 is never mounted if I start the VM. My expectation was that it should work fine to moun...
Feb 16, 1:37 pm 2008
Oleg Nesterov
[PATCH] simplify cpu_hotplug_begin()/put_online_cpus()
cpu_hotplug_begin() must be always called under cpu_add_remove_lock, this means that only one process can be cpu_hotplug.active_writer. So we don't need the cpu_hotplug.writer_queue, we can wake up the ->active_writer directly. Also, fix the comment. Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> --- 25/kernel/cpu.c~1_CPU_HP_LOCK 2008-02-15 16:59:17.000000000 +0300 +++ 25/kernel/cpu.c 2008-02-16 18:36:37.000000000 +0300 @@ -33,17 +33,13 @@ static struct { * an ongoing cpu hotplug o...
Feb 16, 1:22 pm 2008
Oleg Nesterov
[PATCH 1/2] workqueues: shrink cpu_populated_map when CPU dies
When cpu_populated_map was introduced, it was supposed that cwq->thread can survive after CPU_DEAD, that is why we never shrink cpu_populated_map. This is not very nice, we can safely remove the already dead CPU from the map. The only required change is that destroy_workqueue() must hold the hotplug lock until it destroys all cwq->thread's, to protect the cpu_populated_map. We could make the local copy of cpu mask and drop the lock, but sizeof(cpumask_t) may be very large. Also, fix the com...
Feb 16, 1:22 pm 2008
Oleg Nesterov
[PATCH 2/2] cleanup_workqueue_thread: remove the unneeded "c...
cleanup_workqueue_thread() doesn't need the second argument, remove it. Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> --- 25/kernel/workqueue.c~2_CWT_CPU 2008-02-16 19:33:03.000000000 +0300 +++ 25/kernel/workqueue.c 2008-02-16 20:02:51.000000000 +0300 @@ -770,7 +770,7 @@ struct workqueue_struct *__create_workqu } EXPORT_SYMBOL_GPL(__create_workqueue_key); -static void cleanup_workqueue_thread(struct cpu_workqueue_struct *cwq, int cpu) +static void cleanup_workqueue_thread(struct cpu_...
Feb 16, 1:23 pm 2008
Alessandro Suardi
2.6.25-rc2: wpa_supplicant BUGs kernel in rwlock recursion
Fedora 8 / x86, Dell D610, ipw2200 testcase: 1. boot into runlevel 3 2. log on as root on tty1 3. start wpa_supplicant 2.6.25-rc1-git4 is okay 2.6.25-rc2 BUGs dumping stack on console, but nothing gets in /var/log/messages 2.6.25-rc2-git1 BUGs dumping stack on console, ONLY this in /var/log/messages: Feb 16 16:51:49 sandman kernel: BUG: rwlock recursion on CPU#0, wpa_supplicant/2342, c0440220 Will now look for changes between -rc1-git4 and -rc2... .config files are the same for the two...
Feb 16, 1:14 pm 2008
Guillaume Chazarain
Re: 2.6.25-rc2: wpa_supplicant BUGs kernel in rwlock recursion
Same thing here, bisected it to: commit 45b503548210fe6f23e92b856421c2a3f05fd034 Author: Laszlo Attila Toth <panther <at> balabit.hu> Date: Tue Feb 12 22:42:09 2008 -0800 [RTNETLINK]: Send a single notification on device state changes. The revert applies cleanly and fixes the problem. Rafael has more details in http://lkml.org/lkml/2008/2/15/542. -- Guillaume --
Feb 16, 7:18 pm 2008
Alessandro Suardi
Re: 2.6.25-rc2: wpa_supplicant BUGs kernel in rwlock recursion
OK, here goes netconsole output, hoping GMail doesn't munge it too much... Feb 16 20:13:01 sandman kernel: BUG: rwlock recursion on CPU#0, wpa_supplicant/2243, c0440220 Feb 16 20:13:01 sandman kernel: Pid: 2243, comm: wpa_supplicant Not tainted 2.6.25-rc2-git1 #2 Feb 16 20:13:01 sandman kernel: [<c01df8e8>] rwlock_bug+0x36/0x40 Feb 16 20:13:01 sandman kernel: [<c01dfbe2>] _raw_write_lock+0x2e/0x54 Feb 16 20:13:01 sandman kernel: [<c032857f>] _write_lock_bh+0x12/0x15 Feb 16...
Feb 16, 2:27 pm 2008
Roel Kluin
[PATCH] drivers/mtd/onenand/onenand_base.c unlikely(x) || un...
Not yet tested. --- Replace unlikely(x) || unlikely(y) by unlikely(x || y) Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c index 8d7d21b..7334b4a 100644 --- a/drivers/mtd/onenand/onenand_base.c +++ b/drivers/mtd/onenand/onenand_base.c @@ -1336,7 +1336,7 @@ static int onenand_panic_write(struct mtd_info *mtd, loff_t to, size_t len, } /* Reject writes, which are not page aligned */ - if (unl...
Feb 16, 1:14 pm 2008
Roel Kluin
[PATCH] kernel/sched.c unlikely(x) || unlikely(y) => unli...
Not yet tested. --- Replace unlikely(x) || unlikely(y) by unlikely(x || y) Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/kernel/sched.c b/kernel/sched.c index f28f19e..816c299 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -137,7 +137,7 @@ static inline void sg_inc_cpu_power(struct sched_group *sg, u32 val) static inline int rt_policy(int policy) { - if (unlikely(policy == SCHED_FIFO) || unlikely(policy == SCHED_RR)) + if (unlikely(policy == SCHED_FIFO || polic...
Feb 16, 1:09 pm 2008
Bartlomiej Zolnierki...
[PATCH 01/12] ide: remove ide_default_io_ctl() macro
It is always == '((base) + 0x206)' if CONFIG_IDE_ARCH_OBSOLETE_DEFAULTS=y and it is not needed otherwise (arm, blackfin, parisc, ppc64, sh, sparc[64]). Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/ide.c | 2 +- include/asm-alpha/ide.h | 2 -- include/asm-arm/ide.h | 8 -------- include/asm-blackfin/ide.h | 4 ---- include/asm-ia64/ide.h | 2 -- include/asm-m32r/ide.h ...
Feb 16, 12:38 pm 2008
Bartlomiej Zolnierki...
[PATCH 12/12] ide: cleanup ide_find_port()
Remove no longer needed matching against I/O base and 'base' argument. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/arm/bast-ide.c | 2 +- drivers/ide/arm/icside.c | 2 +- drivers/ide/arm/ide_arm.c | 2 +- drivers/ide/arm/palm_bk3710.c | 2 +- drivers/ide/arm/rapide.c | 2 +- drivers/ide/cris/ide-cris.c | 2 +- drivers/ide/h8300/ide-h8300.c | 3 +-- drivers/ide/ide-generic.c | 2...
Feb 16, 12:40 pm 2008
Bartlomiej Zolnierki...
[PATCH 11/12] ide: cleanup ide_match_hwif()
* Remove no longer needed matching against I/O base and 'io_base' argument. * Move printk() to the caller and remove 'name' argument. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/setup-pci.c | 47 +++++++++++++++-------------------------------- 1 file changed, 15 insertions(+), 32 deletions(-) Index: b/drivers/ide/setup-pci.c =================================================================== --- a/drivers/ide/setup-pci.c +++ b/drivers/ide/setup-pci.c...
Feb 16, 12:40 pm 2008
Bartlomiej Zolnierki...
[PATCH 10/12] ide: remove ide_init_default_irq() macro
* Use ide_default_irq() instead of ide_init_default_irq() in ide_generic host driver (so the correct IRQ is always set regardless of CONFIG_PCI / CONFIG_BLK_DEV_IDEPCI). * Remove no longer needed ide_init_default_irq() macro. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/ide-generic.c | 2 +- include/asm-alpha/ide.h | 6 ------ include/asm-ia64/ide.h | 6 ------ include/asm-m32r/ide.h | 6 ----...
Feb 16, 12:40 pm 2008
previous daytodaynext day
February 15, 2008February 16, 2008February 17, 2008