Re: [PATCH 2/2] x86: sparse error in efi_32.c

Previous thread: [PATCH 1/2] x86: sparse warning in efi.c by Harvey Harrison on Wednesday, February 13, 2008 - 2:26 pm. (2 messages)

Next thread: [2.6 patch] make blk-core.c:request_cachep static again by Adrian Bunk on Wednesday, February 13, 2008 - 2:29 pm. (2 messages)
From: Harvey Harrison
Date: Wednesday, February 13, 2008 - 2:26 pm

include/linux/efi.h does not include asm/efi.h, efi.c and efi_64.c
explicitly include both.  While not really right, add the include
to efi_32.c until the header gets sorted out.

arch/x86/kernel/efi_32.c:42:6: warning: symbol 'efi_call_phys_prelog' was not declared. Should it be static?
arch/x86/kernel/efi_32.c:84:6: warning: symbol 'efi_call_phys_epilog' was not declared. Should it be static?

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 arch/x86/kernel/efi_32.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/efi_32.c b/arch/x86/kernel/efi_32.c
index cb91f98..5d23d85 100644
--- a/arch/x86/kernel/efi_32.c
+++ b/arch/x86/kernel/efi_32.c
@@ -28,6 +28,7 @@
 #include <asm/page.h>
 #include <asm/pgtable.h>
 #include <asm/tlbflush.h>
+#include <asm/efi.h>
 
 /*
  * To make EFI call EFI runtime service in physical addressing mode we need
-- 
1.5.4.1.1278.gc75be

--

From: Thomas Gleixner
Date: Saturday, February 16, 2008 - 11:11 am

Applied. Thanks

	 tglx
--

Previous thread: [PATCH 1/2] x86: sparse warning in efi.c by Harvey Harrison on Wednesday, February 13, 2008 - 2:26 pm. (2 messages)

Next thread: [2.6 patch] make blk-core.c:request_cachep static again by Adrian Bunk on Wednesday, February 13, 2008 - 2:29 pm. (2 messages)