[PATCH 10/12] ide: remove ide_init_default_irq() macro

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-ide@...>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@...>, <linux-kernel@...>
Date: Saturday, February 16, 2008 - 12:40 pm

* Use ide_default_irq() instead of ide_init_default_irq() in
  ide_generic host driver (so the correct IRQ is always set
  regardless of CONFIG_PCI / CONFIG_BLK_DEV_IDEPCI).

* Remove no longer needed ide_init_default_irq() macro.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/ide-generic.c           |    2 +-
 include/asm-alpha/ide.h             |    6 ------
 include/asm-ia64/ide.h              |    6 ------
 include/asm-m32r/ide.h              |    6 ------
 include/asm-mips/mach-generic/ide.h |    6 ------
 include/asm-powerpc/ide.h           |    6 ------
 include/asm-x86/ide.h               |    6 ------
 7 files changed, 1 insertion(+), 37 deletions(-)

Index: b/drivers/ide/ide-generic.c
===================================================================
--- a/drivers/ide/ide-generic.c
+++ b/drivers/ide/ide-generic.c
@@ -102,7 +102,7 @@ static int __init ide_generic_init(void)
 
 			memset(&hw, 0, sizeof(hw));
 			ide_std_init_ports(&hw, io_addr, io_addr + 0x206);
-			hw.irq = ide_init_default_irq(io_addr);
+			hw.irq = ide_default_irq(io_addr);
 			ide_init_port_hw(hwif, &hw);
 
 			hwif->noprobe = oldnoprobe;
Index: b/include/asm-alpha/ide.h
===================================================================
--- a/include/asm-alpha/ide.h
+++ b/include/asm-alpha/ide.h
@@ -37,12 +37,6 @@ static inline unsigned long ide_default_
 	}
 }
 
-#ifdef CONFIG_PCI
-#define ide_init_default_irq(base)	(0)
-#else
-#define ide_init_default_irq(base)	ide_default_irq(base)
-#endif
-
 #include <asm-generic/ide_iops.h>
 
 #endif /* __KERNEL__ */
Index: b/include/asm-ia64/ide.h
===================================================================
--- a/include/asm-ia64/ide.h
+++ b/include/asm-ia64/ide.h
@@ -44,12 +44,6 @@ static inline unsigned long ide_default_
 	}
 }
 
-#ifdef CONFIG_PCI
-#define ide_init_default_irq(base)	(0)
-#else
-#define ide_init_default_irq(base)	ide_default_irq(base)
-#endif
-
 #include <asm-generic/ide_iops.h>
 
 #endif /* __KERNEL__ */
Index: b/include/asm-m32r/ide.h
===================================================================
--- a/include/asm-m32r/ide.h
+++ b/include/asm-m32r/ide.h
@@ -63,12 +63,6 @@ static __inline__ unsigned long ide_defa
 	}
 }
 
-#ifdef CONFIG_BLK_DEV_IDEPCI
-#define ide_init_default_irq(base)     (0)
-#else
-#define ide_init_default_irq(base)     ide_default_irq(base)
-#endif
-
 #include <asm-generic/ide_iops.h>
 
 #endif /* __KERNEL__ */
Index: b/include/asm-mips/mach-generic/ide.h
===================================================================
--- a/include/asm-mips/mach-generic/ide.h
+++ b/include/asm-mips/mach-generic/ide.h
@@ -96,12 +96,6 @@ static __inline__ unsigned long ide_defa
 	}
 }
 
-#ifdef CONFIG_BLK_DEV_IDEPCI
-#define ide_init_default_irq(base)	(0)
-#else
-#define ide_init_default_irq(base)	ide_default_irq(base)
-#endif
-
 /* MIPS port and memory-mapped I/O string operations.  */
 static inline void __ide_flush_prologue(void)
 {
Index: b/include/asm-powerpc/ide.h
===================================================================
--- a/include/asm-powerpc/ide.h
+++ b/include/asm-powerpc/ide.h
@@ -73,12 +73,6 @@ static __inline__ unsigned long ide_defa
 	return 0;
 }
 
-#ifdef CONFIG_PCI
-#define ide_init_default_irq(base)	(0)
-#else
-#define ide_init_default_irq(base)	ide_default_irq(base)
-#endif
-
 #ifdef CONFIG_BLK_DEV_MPC8xx_IDE
 #define IDE_ARCH_ACK_INTR  1
 #define ide_ack_intr(hwif) ((hwif)->ack_intr ? (hwif)->ack_intr(hwif) : 1)
Index: b/include/asm-x86/ide.h
===================================================================
--- a/include/asm-x86/ide.h
+++ b/include/asm-x86/ide.h
@@ -58,12 +58,6 @@ static __inline__ unsigned long ide_defa
 	}
 }
 
-#ifdef CONFIG_BLK_DEV_IDEPCI
-#define ide_init_default_irq(base)	(0)
-#else
-#define ide_init_default_irq(base)	ide_default_irq(base)
-#endif
-
 #include <asm-generic/ide_iops.h>
 
 #endif /* __KERNEL__ */
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 01/12] ide: remove ide_default_io_ctl() macro, Bartlomiej Zolnierkiewicz..., (Sat Feb 16, 12:38 pm)
[PATCH 12/12] ide: cleanup ide_find_port(), Bartlomiej Zolnierkiewicz..., (Sat Feb 16, 12:40 pm)
[PATCH 11/12] ide: cleanup ide_match_hwif(), Bartlomiej Zolnierkiewicz..., (Sat Feb 16, 12:40 pm)
[PATCH 10/12] ide: remove ide_init_default_irq() macro, Bartlomiej Zolnierkiewicz..., (Sat Feb 16, 12:40 pm)
[PATCH 09/12] ide: move default IDE ports setup to ide_gener..., Bartlomiej Zolnierkiewicz..., (Sat Feb 16, 12:39 pm)
[PATCH 08/12] ide: remove needless hwif-&gt;irq check from i..., Bartlomiej Zolnierkiewicz..., (Sat Feb 16, 12:39 pm)
[PATCH 07/12] ide: init hwif-&gt;{io_ports,irq} explicitly i..., Bartlomiej Zolnierkiewicz..., (Sat Feb 16, 12:39 pm)
[PATCH 06/12] ide: limit legacy VLB host drivers to alpha, x..., Bartlomiej Zolnierkiewicz..., (Sat Feb 16, 12:39 pm)
[PATCH 05/12] cmd640: init hwif-&gt;{io_ports,irq} explicitly, Bartlomiej Zolnierkiewicz..., (Sat Feb 16, 12:39 pm)
[PATCH 04/12] cmd640: cleanup setup_device_ptrs(), Bartlomiej Zolnierkiewicz..., (Sat Feb 16, 12:39 pm)
[PATCH 03/12] ide: add ide-4drives host driver, Bartlomiej Zolnierkiewicz..., (Sat Feb 16, 12:39 pm)
Re: [PATCH 03/12] ide: add ide-4drives host driver, Sergei Shtylyov, (Tue Feb 19, 9:03 am)
Re: [PATCH 03/12] ide: add ide-4drives host driver, Bartlomiej Zolnierkiewicz..., (Tue Feb 19, 5:24 pm)
Re: [PATCH 03/12] ide: add ide-4drives host driver, Randy Dunlap, (Sat Feb 16, 1:26 pm)
Re: [PATCH 03/12] ide: add ide-4drives host driver, Bartlomiej Zolnierkiewicz..., (Sun Feb 17, 1:12 pm)
[PATCH 02/12] ide: remove ppc ifdef from init_ide_data(), Bartlomiej Zolnierkiewicz..., (Sat Feb 16, 12:39 pm)