Re: [patch 1/6] mmu_notifier: Core code

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Brice Goglin <Brice.Goglin@...>
Cc: Christoph Lameter <clameter@...>, Andrea Arcangeli <andrea@...>, <linux-kernel@...>, <linux-mm@...>
Date: Saturday, February 16, 2008 - 6:58 am

On Sat, 16 Feb 2008 11:41:35 +0100 Brice Goglin <Brice.Goglin@inria.fr> wrote:


"looks good" maybe.  But it's in the details where I fear this will come
unstuck.  The likelihood that some callbacks really will want to be able to
block in places where this interface doesn't permit that - either to wait
for IO to complete or to wait for other threads to clear critical regions.

From that POV it doesn't look like a sufficiently general and useful
design.  Looks like it was grafted onto the current VM implementation in a
way which just about suits two particular clients if they try hard enough.

Which is all perfectly understandable - it would be hard to rework core MM
to be able to make this interface more general.  But I do think it's
half-baked and there is a decent risk that future (or present) code which
_could_ use something like this won't be able to use this one, and will
continue to futz with mlock, page-pinning, etc.

Not that I know what the fix to that is..
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 1/6] mmu_notifier: Core code, Christoph Lameter, (Fri Feb 15, 2:49 am)
Re: [patch 1/6] mmu_notifier: Core code, Roland Dreier, (Mon Feb 18, 6:33 pm)
Re: [patch 1/6] mmu_notifier: Core code, Andrew Morton, (Fri Feb 15, 11:37 pm)
Re: [patch 1/6] mmu_notifier: Core code , Doug Maxey, (Sun Feb 17, 1:04 am)
Re: [patch 1/6] mmu_notifier: Core code, Christoph Lameter, (Sat Feb 16, 3:21 pm)
Re: [patch 1/6] mmu_notifier: Core code, Andrea Arcangeli, (Sat Feb 16, 11:01 pm)
Re: [patch 1/6] mmu_notifier: Core code, Robin Holt, (Sun Feb 17, 8:24 am)
Re: [patch 1/6] mmu_notifier: Core code, Brice Goglin, (Sat Feb 16, 6:41 am)
Re: [patch 1/6] mmu_notifier: Core code, Andrew Morton, (Sat Feb 16, 6:58 am)
Re: [patch 1/6] mmu_notifier: Core code, Christoph Lameter, (Sat Feb 16, 3:31 pm)
Re: [patch 1/6] mmu_notifier: Core code, Avi Kivity, (Sat Feb 16, 4:45 am)
Re: [patch 1/6] mmu_notifier: Core code, Andrew Morton, (Sat Feb 16, 4:56 am)
Re: [patch 1/6] mmu_notifier: Core code, Avi Kivity, (Sat Feb 16, 5:21 am)