Home » Mailing list archives » linux-kernel » 2008 » February » 15

[PATCH 24/30] r/o bind mounts: elevate count for xfs timestamp updates

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dave Hansen <haveblue@...>
To: <linux-kernel@...>
Cc: <hch@...>, <miklos@...>, <akpm@...>, Dave Hansen <haveblue@...>
Subject: [PATCH 24/30] r/o bind mounts: elevate count for xfs timestamp updates
Date: Friday, February 15, 2008 - 6:37 pm

Elevate the write count during the xfs m/ctime updates.

XFS has to do it's own timestamp updates due to an unfortunate VFS
design limitation, so it will have to track writers by itself aswell.

[hch: split out from the touch_atime patch as it's not related to it at all]

Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
---

 linux-2.6.git-dave/fs/xfs/linux-2.6/xfs_iops.c |    7 -------
 linux-2.6.git-dave/fs/xfs/linux-2.6/xfs_lrw.c  |    9 ++++++++-
 2 files changed, 8 insertions(+), 8 deletions(-)

diff -puN fs/xfs/linux-2.6/xfs_iops.c~r-o-bind-mounts-elevate-writer-count-for-xfs-timestamp-updates fs/xfs/linux-2.6/xfs_iops.c
--- linux-2.6.git/fs/xfs/linux-2.6/xfs_iops.c~r-o-bind-mounts-elevate-writer-count-for-xfs-timestamp-updates	2008-02-15 13:25:56.000000000 -0800
+++ linux-2.6.git-dave/fs/xfs/linux-2.6/xfs_iops.c	2008-02-15 13:25:56.000000000 -0800
@@ -157,13 +157,6 @@ xfs_ichgtime_fast(
 	 */
 	ASSERT((flags & XFS_ICHGTIME_ACC) == 0);
 
-	/*
-	 * We're not supposed to change timestamps in readonly-mounted
-	 * filesystems.  Throw it away if anyone asks us.
-	 */
-	if (unlikely(IS_RDONLY(inode)))
-		return;
-
 	if (flags & XFS_ICHGTIME_MOD) {
 		tvp = &inode->i_mtime;
 		ip->i_d.di_mtime.t_sec = (__int32_t)tvp->tv_sec;
diff -puN fs/xfs/linux-2.6/xfs_lrw.c~r-o-bind-mounts-elevate-writer-count-for-xfs-timestamp-updates fs/xfs/linux-2.6/xfs_lrw.c
--- linux-2.6.git/fs/xfs/linux-2.6/xfs_lrw.c~r-o-bind-mounts-elevate-writer-count-for-xfs-timestamp-updates	2008-02-15 13:25:56.000000000 -0800
+++ linux-2.6.git-dave/fs/xfs/linux-2.6/xfs_lrw.c	2008-02-15 13:25:56.000000000 -0800
@@ -51,6 +51,7 @@
 #include "xfs_vnodeops.h"
 
 #include <linux/capability.h>
+#include <linux/mount.h>
 #include <linux/writeback.h>
 
 
@@ -679,10 +680,16 @@ start:
 	if (new_size > xip->i_size)
 		xip->i_new_size = new_size;
 
-	if (likely(!(ioflags & IO_INVIS))) {
+	/*
+	 * We're not supposed to change timestamps in readonly-mounted
+	 * filesystems.  Throw it away if anyone asks us.
+	 */
+	if (likely(!(ioflags & IO_INVIS) &&
+		   !mnt_want_write(file->f_vfsmnt))) {
 		file_update_time(file);
 		xfs_ichgtime_fast(xip, inode,
 				  XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
+		mnt_drop_write(file->f_vfsmnt);
 	}
 
 	/*
_
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/30] Read-only bind mounts (-mm resend), Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH] r/o bind mounts: stub functions, Dave Hansen, (Fri Feb 15, 9:32 pm)
[PATCH 30/30] r/o bind mounts: debugging for missed calls, Dave Hansen, (Fri Feb 15, 6:38 pm)
[PATCH 29/30] r/o bind mounts: honor mount writer counts at ..., Dave Hansen, (Fri Feb 15, 6:38 pm)
[PATCH 28/30] r/o bind mounts: track numbers of writers to m..., Dave Hansen, (Fri Feb 15, 6:37 pm)
Re: [PATCH 28/30] r/o bind mounts: track numbers of writers ..., Miklos Szeredi, (Mon Feb 18, 12:10 pm)
Re: [PATCH 28/30] r/o bind mounts: track numbers of writers ..., Dave Hansen, (Wed Feb 20, 5:12 pm)
[PATCH 27/30] r/o bind mounts: get callers of vfs_mknod/crea..., Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 26/30] r/o bind mounts: check mnt instead of superblo..., Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 22/30] r/o bind mounts: elevate write count for chmod..., Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 25/30] r/o bind mounts: make access() use new r/o hel..., Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 24/30] r/o bind mounts: elevate count for xfs timesta..., Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 23/30] r/o bind mounts: write counts for truncate(), Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 21/30] r/o bind mounts: get write access for vfs_rena..., Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 20/30] r/o bind mounts: elevate write count for open()s, Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 19/30] r/o bind mounts: elevate write count for ioctl..., Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 18/30] r/o bind mounts: write counts for link/symlink, Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 17/30] r/o bind mounts: write count for file_update_t..., Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 06/30] merge open_namei() and do_filp_open(), Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 16/30] r/o bind mounts: elevate write count for do_ut..., Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 15/30] r/o bind mounts: write counts for time functions, Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 14/30] r/o bind mounts: elevate write count for ncp_i..., Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 13/30] r/o bind mounts: elevate write count for xattr..., Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 12/30] r/o bind mounts: elevate mnt_writers for unlin..., Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 11/30] r/o bind mounts: elevate write count for calle..., Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 10/30] r/o bind mounts: elevate write count for vfs_r..., Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 08/30] r/o bind mounts: create helper to drop file wr..., Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 05/30] do namei_flags calculation inside open_namei(), Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 03/30] check for null vfsmount in dentry_open(), Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 07/30] r/o bind mounts: stub functions, Dave Hansen, (Fri Feb 15, 6:37 pm)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Theodore Tso, (Fri Feb 15, 8:32 pm)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Dave Hansen, (Fri Feb 15, 8:49 pm)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Theodore Tso, (Fri Feb 15, 9:00 pm)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Andrew Morton, (Fri Feb 15, 9:11 pm)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Christoph Hellwig, (Sat Feb 16, 2:31 am)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Dave Hansen, (Wed Feb 20, 6:25 pm)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Christoph Hellwig, (Wed Feb 20, 6:58 pm)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Andrew Morton, (Sat Feb 16, 2:46 am)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Dave Hansen, (Mon Feb 18, 3:06 am)
[PATCH 09/30] r/o bind mounts: drop write during emergency r..., Dave Hansen, (Fri Feb 15, 6:37 pm)
Re: [PATCH 09/30] r/o bind mounts: drop write during emergen..., Miklos Szeredi, (Mon Feb 18, 12:29 pm)
Re: [PATCH 09/30] r/o bind mounts: drop write during emergen..., Al Viro, (Sat Feb 23, 9:38 am)
[PATCH 01/30] reiserfs: eliminate private use of struct file..., Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 04/30] fix up new filp allocators, Dave Hansen, (Fri Feb 15, 6:37 pm)
[PATCH 02/30] hppfs pass vfsmount to dentry_open(), Dave Hansen, (Fri Feb 15, 6:37 pm)