Home » Mailing list archives » linux-kernel » 2008 » February » 15

[PATCH 12/30] r/o bind mounts: elevate mnt_writers for unlink callers

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dave Hansen
Subject: [PATCH 12/30] r/o bind mounts: elevate mnt_writers for unlink callers
Date: Friday, February 15, 2008 - 3:37 pm

Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
---

 linux-2.6.git-dave/fs/namei.c   |    4 ++++
 linux-2.6.git-dave/ipc/mqueue.c |    5 ++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff -puN fs/namei.c~r-o-bind-mounts-elevate-mnt-writers-for-vfs_unlink-callers fs/namei.c
--- linux-2.6.git/fs/namei.c~r-o-bind-mounts-elevate-mnt-writers-for-vfs_unlink-callers	2008-02-15 13:25:48.000000000 -0800
+++ linux-2.6.git-dave/fs/namei.c	2008-02-15 13:25:48.000000000 -0800
@@ -2280,7 +2280,11 @@ static long do_unlinkat(int dfd, const c
 		inode = dentry->d_inode;
 		if (inode)
 			atomic_inc(&inode->i_count);
+		error = mnt_want_write(nd.path.mnt);
+		if (error)
+			goto exit2;
 		error = vfs_unlink(nd.path.dentry->d_inode, dentry);
+		mnt_drop_write(nd.path.mnt);
 	exit2:
 		dput(dentry);
 	}
diff -puN ipc/mqueue.c~r-o-bind-mounts-elevate-mnt-writers-for-vfs_unlink-callers ipc/mqueue.c
--- linux-2.6.git/ipc/mqueue.c~r-o-bind-mounts-elevate-mnt-writers-for-vfs_unlink-callers	2008-02-15 13:25:48.000000000 -0800
+++ linux-2.6.git-dave/ipc/mqueue.c	2008-02-15 13:25:48.000000000 -0800
@@ -742,8 +742,11 @@ asmlinkage long sys_mq_unlink(const char
 	inode = dentry->d_inode;
 	if (inode)
 		atomic_inc(&inode->i_count);
-
+	err = mnt_want_write(mqueue_mnt);
+	if (err)
+		goto out_err;
 	err = vfs_unlink(dentry->d_parent->d_inode, dentry);
+	mnt_drop_write(mqueue_mnt);
 out_err:
 	dput(dentry);
 
_
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/30] Read-only bind mounts (-mm resend), Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 01/30] reiserfs: eliminate private use of struct fi ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 02/30] hppfs pass vfsmount to dentry_open(), Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 03/30] check for null vfsmount in dentry_open(), Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 04/30] fix up new filp allocators, Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 05/30] do namei_flags calculation inside open_namei(), Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 06/30] merge open_namei() and do_filp_open(), Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 07/30] r/o bind mounts: stub functions, Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 08/30] r/o bind mounts: create helper to drop file ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 09/30] r/o bind mounts: drop write during emergency ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 10/30] r/o bind mounts: elevate write count for vfs ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 11/30] r/o bind mounts: elevate write count for cal ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 12/30] r/o bind mounts: elevate mnt_writers for unl ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 13/30] r/o bind mounts: elevate write count for xat ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 14/30] r/o bind mounts: elevate write count for ncp ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 15/30] r/o bind mounts: write counts for time functions, Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 16/30] r/o bind mounts: elevate write count for do_ ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 17/30] r/o bind mounts: write count for file_update ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 18/30] r/o bind mounts: write counts for link/symlink, Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 19/30] r/o bind mounts: elevate write count for ioc ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 20/30] r/o bind mounts: elevate write count for open()s, Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 21/30] r/o bind mounts: get write access for vfs_re ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 22/30] r/o bind mounts: elevate write count for chm ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 23/30] r/o bind mounts: write counts for truncate(), Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 24/30] r/o bind mounts: elevate count for xfs times ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 25/30] r/o bind mounts: make access() use new r/o h ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 26/30] r/o bind mounts: check mnt instead of superb ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 27/30] r/o bind mounts: get callers of vfs_mknod/cr ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 28/30] r/o bind mounts: track numbers of writers to ..., Dave Hansen, (Fri Feb 15, 3:37 pm)
[PATCH 29/30] r/o bind mounts: honor mount writer counts a ..., Dave Hansen, (Fri Feb 15, 3:38 pm)
[PATCH 30/30] r/o bind mounts: debugging for missed calls, Dave Hansen, (Fri Feb 15, 3:38 pm)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Theodore Tso, (Fri Feb 15, 5:32 pm)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Dave Hansen, (Fri Feb 15, 5:49 pm)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Theodore Tso, (Fri Feb 15, 6:00 pm)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Andrew Morton, (Fri Feb 15, 6:11 pm)
[PATCH] r/o bind mounts: stub functions, Dave Hansen, (Fri Feb 15, 6:32 pm)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Christoph Hellwig, (Fri Feb 15, 11:31 pm)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Andrew Morton, (Fri Feb 15, 11:46 pm)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Dave Hansen, (Mon Feb 18, 12:06 am)
Re: [PATCH 28/30] r/o bind mounts: track numbers of writer ..., Miklos Szeredi, (Mon Feb 18, 9:10 am)
Re: [PATCH 09/30] r/o bind mounts: drop write during emerg ..., Miklos Szeredi, (Mon Feb 18, 9:29 am)
Re: [PATCH 28/30] r/o bind mounts: track numbers of writer ..., Dave Hansen, (Wed Feb 20, 2:12 pm)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Dave Hansen, (Wed Feb 20, 3:25 pm)
Re: [PATCH 07/30] r/o bind mounts: stub functions, Christoph Hellwig, (Wed Feb 20, 3:58 pm)
Re: [PATCH 09/30] r/o bind mounts: drop write during emerg ..., Al Viro, (Sat Feb 23, 6:38 am)