On Fri, 2008-02-15 at 13:19 -0800, Andrew Morton wrote:
quoted text
> On Fri, 15 Feb 2008 10:46:04 -0800
> Harvey Harrison <harvey.harrison@gmail.com> wrote:
> 
> > Use link as the variable name to avoid shadowing the arg.
> > 
> > fs/befs/linuxvfs.c:492:8: warning: symbol 'p' shadows an earlier one
> > fs/befs/linuxvfs.c:488:77: originally declared here
> > 
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> > ---
> > This should be checked in case there is a latent bug here.  Should it
> > be the arg *p getting freed, or the local var *p that was shadowing
> > it?
> > 
> 
> The code looks OK - the name was allocated in befs_follow_link() and was
> saved away with nd_set_link().

OK, that's as far as I got as well, but don't know the area well enough
to be sure, hence the caveat.

Harvey

--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/