Re: [patch] checkpatch.pl: revert wrong --file message

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Linus Torvalds <torvalds@...>, <linux-kernel@...>, Andy Whitcroft <andyw@...>
Date: Friday, February 15, 2008 - 1:15 pm

> 

I found this doesn't work unfortunately. 

I actively worked with a few people who sent continuous streams of formatting
only checkpatch.pl patches in the last months trying to get them to graduate to 
more complex patches and found they always had to little C knowledge to actively 
contribute something actually useful to the kernel.

At the end I usually had to give them the honest advice "You need to learn
more C first, but I'm afraid the kernel is not the best place to learn C
because it is too unforgiving".

I'm all for actively recruiting new developers (and I think I did my fair 
share on that front), but trying to turn absolute C newbies into
kernel hackers short term just doesn't work. 

On the other hand I found that people who already know enough C and start 
hacking code directly do not really need the "white space only" stage.
They just start hacking code directly. They usually need some education
on how to properly send patches, but that can be always done with
real bug fixes or changes they did.

Out of that experience came the checkpatch.pl message.

-Andi

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch] checkpatch.pl: revert wrong --file message, Ingo Molnar, (Fri Feb 15, 12:52 pm)
Re: [patch] checkpatch.pl: revert wrong --file message, Andi Kleen, (Fri Feb 15, 1:15 pm)
Re: [patch] checkpatch.pl: revert wrong --file message, Thomas Gleixner, (Sat Feb 16, 6:18 am)
Re: [patch] checkpatch.pl: revert wrong --file message, Pekka Enberg, (Sat Feb 16, 6:27 am)
Re: [patch] checkpatch.pl: revert wrong --file message, Andy Whitcroft, (Sat Feb 16, 6:56 pm)
Re: [patch] checkpatch.pl: revert wrong --file message, Thomas Gleixner, (Sat Feb 16, 7:47 pm)
Re: [patch] checkpatch.pl: revert wrong --file message, Cyrill Gorcunov, (Sat Feb 16, 7:04 am)