login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
February
»
14
Re: [PATCH] usb: serial: move zte MF330 from sierra to option
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Andrew Morton
Subject:
Re: [PATCH] usb: serial: move zte MF330 from sierra to option
Date: Thursday, February 14, 2008 - 2:12 pm
On Mon, 11 Feb 2008 12:29:33 -0800 Kevin Lloyd <klloyd@sierrawireless.com> wrote:
quoted text
> From: Kevin Lloyd <linux@sierrawireless.com> > > Moves the Onda H600/ZTE MF33 device from the sierra driver to the option driver. >
A changelog should describe why a change was made, not simply what the change is.
quoted text
> > --- > drivers/usb/serial/sierra.c | 1 - > drivers/usb/serial/option.c | 2 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > --- linux-2.6.25-rc1/drivers/usb/serial/sierra.c.orig 2008-02-11 11:34:06.000000000 -0800 > +++ linux-2.6.25-rc1/drivers/usb/serial/sierra.c 2008-02-11 11:34:36.000000000 -0800 > @@ -178,7 +178,6 @@ static struct usb_device_id id_table [] > > { USB_DEVICE(0x1199, 0x0112), .driver_info = DEVICE_1_PORT }, /* Sierra Wireless AirCard 580 */ > { USB_DEVICE(0x0F3D, 0x0112), .driver_info = DEVICE_1_PORT }, /* Airprime/Sierra PC 5220 */ > - { USB_DEVICE(0x05C6, 0x6613), .driver_info = DEVICE_1_PORT }, /* Onda H600/ZTE MF330 */ > > { USB_DEVICE(0x1199, 0x0FFF), .driver_info = DEVICE_INSTALLER}, > { } > --- linux-2.6.25-rc1/drivers/usb/serial/option.c.orig 2008-02-11 11:42:10.000000000 -0800 > +++ linux-2.6.25-rc1/drivers/usb/serial/option.c 2008-02-11 11:42:18.000000000 -0800 > @@ -121,6 +121,8 @@ static int option_send_setup(struct usb > #define BANDRICH_PRODUCT_C100_1 0x1002 > #define BANDRICH_PRODUCT_C100_2 0x1003 > > +#define QUALCOMM_VENDOR_ID 0x05C6 > + > static struct usb_device_id option_ids[] = { > { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_COLT) }, > { USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_RICOLA) }, > @@ -186,6 +188,7 @@ static struct usb_device_id option_ids[] > { USB_DEVICE(ANYDATA_VENDOR_ID, ANYDATA_PRODUCT_ADU_500A) }, > { USB_DEVICE(BANDRICH_VENDOR_ID, BANDRICH_PRODUCT_C100_1) }, > { USB_DEVICE(BANDRICH_VENDOR_ID, BANDRICH_PRODUCT_C100_2) }, > + { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */ > { } /* Terminating entry */ > }; > MODULE_DEVICE_TABLE(usb, option_ids);
Because I, for one, don't have a clue why you did this? --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] usb: serial: move zte MF330 from sierra to option
, Kevin Lloyd
, (Mon Feb 11, 1:29 pm)
Re: [PATCH] usb: serial: move zte MF330 from sierra to option
, Andrew Morton
, (Thu Feb 14, 2:12 pm)
Re: [PATCH] usb: serial: move zte MF330 from sierra to option
, Greg KH
, (Thu Feb 14, 2:25 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Fortier,Vincent [Montreal]
2.6.21.5 june 30th to july 1st date hang?
Jeff Dike
[ PATCH 2/6 ] UML - Formatting fixes around os_{read_write}_file callers
Liam Girdwood
[PATCH 07/13] regulator: regulator test harness
Oleg Nesterov
Re: Getting the new RxRPC patches upstream
Stefan Seyfried
Re: 2.6.19-rc5: grub is much slower resuming from suspend-to-disk than in 2.6.18
linux-netdev
:
Arnaud Ebalard
Re: [REGRESSION,BISECTED] MIPv6 support broken by f4f914b58019f0
Jan Engelhardt
Re: [PATCH iptables] extension: add xt_cpu match
Jarek Poplawski
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Sebastian Andrzej Siewior
[PATCH 8/8] net/emergency: remove locking from reycling pool if emergncy pools are...
David Miller
Re: [PATCH] qlcnic: dont assume NET_IP_ALIGN is 2
git
:
Jakub Narebski
Re: git on MacOSX and files with decomposed utf-8 file names
Brandon Casey
Re: Thunderbird and patches (was Re: [PATCH v2] Enable setting attach as the def...
Christian Couder
[PATCH 1/3] rev-parse: add test script for "--verify"
Ramkumar Ramachandra
Re: [GSoC update] git-remote-svn: The final one
Junio C Hamano
Re: git-rm isn't the inverse action of git-add
openbsd-misc
:
Joachim Schipper
Re: UVC Webcams
Florin Andrei
SOLVED [was: firewall is very slow, something's wrong]
Todd Alan Smith
Re: Microsoft gets the Most Secure Operating Systems award
Neal Hogan
Re: Need Advice: Thinkpad T60 or T61?
Sam Fourman Jr.
Re: Real men don't attack straw men
git-commits-head
:
Linux Kernel Mailing List
ACPI: Disable ARB_DISABLE on platforms where it is not needed
Linux Kernel Mailing List
m68knommu: add read_barrier_depends() and irqs_disabled_flags()
Linux Kernel Mailing List
[MTD] Add mtd panic_write function pointer
Linux Kernel Mailing List
[ARM] pxa: remove duplicate select statements from Kconfig
Linux Kernel Mailing List
mlx4_core: Don't read reserved fields in mlx4_QUERY_ADAPTER()
Colocation donated by:
Syndicate