On 02/14/2008 03:44 PM, Jiri Slaby wrote:
quoted text
> Hi,
> 
> commit
> 99109301d103fbf0de43fc5a580a406c12a501e0
> in jejb/scsi-rc-fixes-2.6.git is incorrect. You don't decrement pci 
> refcount on exit. Also you do not so on fail paths... I wonder why these 
> mistakes happen every second time somebody tries to do such change.
> 
> It leaked into mainline yet after "whole" two days, but what exactly 
> drives me crazy is, that Jeff commented it in similar way and nobody 
> reflected it!

BTW if you have more than one card, you protected the driver from no race, since 
you don't pci_dev_get of successfully grabbed cards.
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/