Home » Mailing list archives » linux-kernel » 2008 » February » 14

[PATCH] adfs: trivial sparse fix

Previous thread: [PATCH] inotify: make variables static in inotify_user.c by Harvey Harrison on Wednesday, February 13, 2008 - 9:54 pm. (1 message)

Next thread: Driver removals by Bill Davidsen on Wednesday, February 13, 2008 - 10:26 pm. (11 messages)
[view original message]
From: Harvey Harrison <harvey.harrison@...>
To: Russell King <rmk@...>, Andrew Morton <akpm@...>
Cc: LKML <linux-kernel@...>
Subject: [PATCH] adfs: trivial sparse fix
Date: Wednesday, February 13, 2008 - 10:07 pm

fs/adfs/dir_f.c:126:4: warning: do-while statement is not a compound statement


Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>

---

 fs/adfs/dir_f.c |    4 ++--

 1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/fs/adfs/dir_f.c b/fs/adfs/dir_f.c

index b9b2b27..ea7df21 100644

--- a/fs/adfs/dir_f.c

+++ b/fs/adfs/dir_f.c

@@ -122,9 +122,9 @@ adfs_dir_checkbyte(const struct adfs_dir *dir)

 		ptr.ptr8 = bufoff(bh, i);

 		end.ptr8 = ptr.ptr8 + last - i;


-		do

+		do {

 			dircheck = *ptr.ptr8++ ^ ror13(dircheck);

-		while (ptr.ptr8 < end.ptr8);

+		} while (ptr.ptr8 < end.ptr8);

 	}


 	/*

--

1.5.4.1.1278.gc75be


--
[view original message]
From: Andrew Morton <akpm@...>
To: Harvey Harrison <harvey.harrison@...>
Cc: Russell King <rmk@...>, LKML <linux-kernel@...>
Subject: Re: [PATCH] adfs: trivial sparse fix
Date: Wednesday, February 13, 2008 - 11:39 pm

eh?  It's sparse which needs fixing here, surely?

--
[view original message]
From: Harvey Harrison <harvey.harrison@...>
To: Andrew Morton <akpm@...>
Cc: Russell King <rmk@...>, LKML <linux-kernel@...>
Subject: Re: [PATCH] adfs: trivial sparse fix
Date: Wednesday, February 13, 2008 - 11:52 pm

Well, I only 'fixed' it this way to match the surrounding code.  The

warning is a little odd.


Harvey


--
[view original message]
From: Andrew Morton <akpm@...>
To: Harvey Harrison <harvey.harrison@...>
Cc: Russell King <rmk@...>, LKML <linux-kernel@...>
Subject: Re: [PATCH] adfs: trivial sparse fix
Date: Thursday, February 14, 2008 - 12:04 am

Yup, well, I changed the title to something sufficiently rude to get a

reaction from Linus when it crosses his desk.  We'll see ;)


--
Previous thread: [PATCH] inotify: make variables static in inotify_user.c by Harvey Harrison on Wednesday, February 13, 2008 - 9:54 pm. (1 message)

Next thread: Driver removals by Bill Davidsen on Wednesday, February 13, 2008 - 10:26 pm. (11 messages)