Re: [PATCH] enclosure: add support for enclosure services

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: James Bottomley
Date: Wednesday, February 13, 2008 - 11:17 am

On Wed, 2008-02-13 at 09:45 -0800, Kristen Carlson Accardi wrote:

I'm not necessarily arguing against that.  However, what you're
providing is slightly more than just a userspace tap into the enclosure.
You're adding a file to display and control the enclosure state
(sw_activity).  This constitutes an ad-hoc sysfs interface.  I'm not
telling you not to do it, but I am pleading that if we have to have all
these sysfs interfaces, lets at least do it in a uniform way.

Enclosures are such nasty beasts, that even the job of getting a tap
into them is problematic, so if we have a different tap infrastructure
for every different enclosure type and connection it's still going to be
pretty unmanageable to a userspace interface.


James


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] enclosure: add support for enclosure services, James Bottomley, (Sun Feb 3, 2:40 pm)
Re: [PATCH] enclosure: add support for enclosure services, James Bottomley, (Sun Feb 3, 5:16 pm)
Re: [PATCH] enclosure: add support for enclosure services, James Bottomley, (Mon Feb 4, 5:41 pm)
Re: [PATCH] enclosure: add support for enclosure services, James Bottomley, (Mon Feb 4, 7:14 pm)
Re: [PATCH] enclosure: add support for enclosure services, James Bottomley, (Mon Feb 4, 9:37 pm)
Re: [PATCH] enclosure: add support for enclosure services, James Bottomley, (Tue Feb 5, 8:01 am)
Re: [PATCH] enclosure: add support for enclosure services, James Bottomley, (Tue Feb 5, 1:29 pm)
Re: [PATCH] enclosure: add support for enclosure services, James Bottomley, (Tue Feb 5, 7:57 pm)
Re: [PATCH] enclosure: add support for enclosure services, Kristen Carlson Accardi, (Tue Feb 12, 11:22 am)
Re: [PATCH] enclosure: add support for enclosure services, James Bottomley, (Tue Feb 12, 11:45 am)
Re: [PATCH] enclosure: add support for enclosure services, Kristen Carlson Accardi, (Tue Feb 12, 12:07 pm)
Re: [PATCH] enclosure: add support for enclosure services, James Bottomley, (Tue Feb 12, 12:28 pm)
Re: [PATCH] enclosure: add support for enclosure services, Luben Tuikov, (Tue Feb 12, 12:45 pm)
Re: [PATCH] enclosure: add support for enclosure services, James Bottomley, (Wed Feb 13, 9:04 am)
Re: [PATCH] enclosure: add support for enclosure services, James Bottomley, (Wed Feb 13, 9:43 am)
Re: [PATCH] enclosure: add support for enclosure services, Kristen Carlson Accardi, (Wed Feb 13, 10:45 am)
Re: [PATCH] enclosure: add support for enclosure services, James Bottomley, (Wed Feb 13, 11:17 am)