Home » Mailing list archives » linux-kernel » 2008 » February » 13

[drivers/video/sis/init301.c] SiS_Pr->ChipType >= SIS_661 not evaluated twice

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roel Kluin <12o3l@...>
To: <thomas@...>, lkml <linux-kernel@...>
Subject: [drivers/video/sis/init301.c] SiS_Pr-&gt;ChipType &gt;= SIS_661 not evaluated twice
Date: Wednesday, February 13, 2008 - 7:00 am

Not sure whether this is important, but in drivers/video/sis/init301.c:1557:

  if((SiS_Pr->ChipType >= SIS_661) || (SiS_Pr->SiS_ROMNew)) {
     SiS_Pr->SiS_LCDTypeInfo = (SiS_GetReg(SiS_Pr->SiS_P3d4,0x39) & 0x7c) >> 2;
  } else if((SiS_Pr->ChipType < SIS_315H) || (SiS_Pr->ChipType >= SIS_661)) {
     SiS_Pr->SiS_LCDTypeInfo = temp >> 4;

note the duplicate test for 'SiS_Pr->ChipType >= SIS_661'
if it was true in the first test, the second test won't be evaluated.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[drivers/video/sis/init301.c] SiS_Pr->ChipType >= SIS_..., Roel Kluin, (Wed Feb 13, 7:00 am)