login
Header Space

 
 

[libata-dev #upstream-fixes] pata_legacy: don't call ata_host_detach() after initialization failure

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Arjan van de Ven <arjan@...>, <linux-kernel@...>, Linus Torvalds <torvalds@...>, Mark Lord <mlord@...>, Jeff Garzik <jeff@...>, Alan Cox <alan@...>, IDE/ATA development list <linux-ide@...>
Date: Wednesday, February 13, 2008 - 5:20 am

ata_host_detach() detaches an attached port and shouldn't be called on
a port which hasn't been attached yet.  pata_legacy incorrectly calls
ata_host_detach() on unattached port after initialization failure
causing oops.  Fix it.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Arjan van de Ven <arjan@infradead.org>
---
 drivers/ata/pata_legacy.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/ata/pata_legacy.c b/drivers/ata/pata_legacy.c
index 333dc15..7383f19 100644
--- a/drivers/ata/pata_legacy.c
+++ b/drivers/ata/pata_legacy.c
@@ -1278,8 +1278,6 @@ static __init int legacy_init_one(struct legacy_probe *probe)
 		}
 	}
 fail:
-	if (host)
-		ata_host_detach(host);
 	platform_device_unregister(pdev);
 	return ret;
 }
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Linux 2.6.25-rc1, Linus Torvalds, (Sun Feb 10, 8:44 pm)
[ata crash] Re: Linux 2.6.25-rc1, Ingo Molnar, (Tue Feb 12, 4:18 am)
Re: [ata crash] Re: Linux 2.6.25-rc1, Tejun Heo, (Wed Feb 13, 5:51 am)
Re: [ata crash] Re: Linux 2.6.25-rc1, Tejun Heo, (Wed Feb 20, 10:33 pm)
Re: [ata crash] Re: Linux 2.6.25-rc1, Ingo Molnar, (Thu Feb 21, 3:12 am)
Re: [ata crash] Re: Linux 2.6.25-rc1, Arjan van de Ven, (Tue Feb 12, 11:14 am)
Re: [ata crash] Re: Linux 2.6.25-rc1, Ingo Molnar, (Wed Feb 13, 5:01 am)
[libata-dev #upstream-fixes] pata_legacy: don't call ata_hos..., Tejun Heo, (Wed Feb 13, 5:20 am)
Re: Linux 2.6.25-rc1, Torsten Kaiser, (Mon Feb 11, 5:46 pm)
Re: Linux 2.6.25-rc1, Andrew Morton, (Mon Feb 11, 6:15 pm)
Re: Linux 2.6.25-rc1, Torsten Kaiser, (Wed Feb 13, 3:17 pm)
Re: Linux 2.6.25-rc1, Stefan Richter, (Mon Feb 11, 6:48 pm)
Re: Linux 2.6.25-rc1, Sam Ravnborg, (Mon Feb 11, 9:31 am)
[PATCH] kbuild: fix make V=1, Sam Ravnborg, (Mon Feb 11, 12:47 pm)
Re: [PATCH] kbuild: fix make V=1, Oleg Verych, (Mon Feb 11, 7:38 pm)
Re: [PATCH] kbuild: fix make V=1, Sam Ravnborg, (Tue Feb 12, 4:56 am)
Re: [PATCH] kbuild: fix make V=1, Oleg Verych, (Tue Feb 12, 5:25 am)
Re: [PATCH] kbuild: fix make V=1, Sam Ravnborg, (Tue Feb 12, 4:01 pm)
Re: [PATCH] kbuild: fix make V=1, Mike Frysinger, (Tue Feb 12, 11:07 am)
Re: [PATCH] kbuild: fix make V=1, Oleg Verych, (Tue Feb 12, 11:49 am)
Re: [PATCH] kbuild: fix make V=1, Mike Frysinger, (Tue Feb 12, 12:18 pm)
Re: [PATCH] kbuild: fix make V=1, Oleg Verych, (Tue Feb 12, 12:42 pm)
Re: Linux 2.6.25-rc1, Mike Frysinger, (Mon Feb 11, 12:17 pm)
parisc - error: 'VMALLOC_START' undeclared..., Domenico Andreoli, (Mon Feb 11, 7:19 am)
Re: parisc - error: 'VMALLOC_START' undeclared..., Adrian Bunk, (Mon Feb 11, 8:06 am)
Re: Linux 2.6.25-rc1, Brice Goglin, (Mon Feb 11, 3:39 am)
Re: Linux 2.6.25-rc1, Arjan van de Ven, (Mon Feb 11, 11:16 am)
Re: Linux 2.6.25-rc1, Gene Heskett, (Sun Feb 10, 11:14 pm)
Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;', Mr. James W. Laferriere, (Sun Feb 10, 9:47 pm)
Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;', Mr. James W. Laferriere, (Mon Feb 11, 11:37 pm)
Re: Linux 2.6.25-rc1, Sergio Luis, (Sun Feb 10, 9:36 pm)
speck-geostationary