On Wed, 13 Feb 2008, Al Viro wrote:Hmm. "-r" is a no-op to git-cherry-pick. And even if you thought it should preserve committer information, it really _really_ shouldn't. You're creating a new commit, you're the new committer. The old committer is meaningless. It doesn't matter at all if you try to keep the old committer information (which you can do by faking GIT_COMMITER_NAME¦EMAIL): you're simply just _lying_ at that point. The original committer has a different commit in his tree, and if you try to claim that your cherry-picked commit is his, you're only doing everybody a disservice. If you meant using "-x", then yes, that retains the actual pointer to the original commit, but it's not the default, because it shouldn't be used unless you plan to carry both around on purpose (ie it's mainly useful for "maintain a stable branch that has commits cherry-picked from mainline" kinds of things). Linus --
| Joe Perches | [PATCH 143/148] include/asm-x86/vm86.h: checkpatch cleanups - formatting only |
| Linus Torvalds | Re: Back to the future. |
| Greg Kroah-Hartman | [PATCH 004/196] Chinese: add translation of SubmittingPatches |
| Trent Piepho | [PATCH] [POWERPC] Improve (in|out)_beXX() asm code |
git: | |
| David Miller | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Gerrit Renker | [PATCH 15/37] dccp: Set per-connection CCIDs via socket options |
| David Miller | [GIT]: Networking |
| Linus Torvalds | Re: iptables very slow after commit 784544739a25c30637397ace5489eeb6e15d7d49 |
