[PATCH] scsi: le*_add_cpu conversion

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: LKML <linux-kernel@...>
Cc: Marcin Slusarz <marcin.slusarz@...>, <linux-scsi@...>, <aacraid@...>, <James.Bottomley@...>
Date: Tuesday, February 12, 2008 - 7:06 pm

From: Marcin Slusarz <marcin.slusarz@gmail.com>

replace all:
little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) +
					expression_in_cpu_byteorder);
with:
	leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder);
generated with semantic patch

Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: linux-scsi@vger.kernel.org
Cc: aacraid@adaptec.com
Cc: James.Bottomley@HansenPartnership.com
---
 drivers/scsi/aacraid/commsup.c |    2 +-
 drivers/scsi/ips.c             |    8 ++------
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index 81b3692..3ac8c82 100644
--- a/drivers/scsi/aacraid/commsup.c
+++ b/drivers/scsi/aacraid/commsup.c
@@ -594,7 +594,7 @@ void aac_consumer_free(struct aac_dev * dev, struct aac_queue *q, u32 qid)
 	if (le32_to_cpu(*q->headers.consumer) >= q->entries)
 		*q->headers.consumer = cpu_to_le32(1);
 	else
-		*q->headers.consumer = cpu_to_le32(le32_to_cpu(*q->headers.consumer)+1);
+		le32_add_cpu(q->headers.consumer, 1);
 
 	if (wasfull) {
 		switch (qid) {
diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c
index bb152fb..f45770a 100644
--- a/drivers/scsi/ips.c
+++ b/drivers/scsi/ips.c
@@ -3696,9 +3696,7 @@ ips_send_cmd(ips_ha_t * ha, ips_scb_t * scb)
 			scb->cmd.basic_io.sg_count = scb->sg_len;
 
 			if (scb->cmd.basic_io.lba)
-				scb->cmd.basic_io.lba =
-				    cpu_to_le32(le32_to_cpu
-						(scb->cmd.basic_io.lba) +
+				le32_add_cpu(&scb->cmd.basic_io.lba,
 						le16_to_cpu(scb->cmd.basic_io.
 							    sector_count));
 			else
@@ -3744,9 +3742,7 @@ ips_send_cmd(ips_ha_t * ha, ips_scb_t * scb)
 			scb->cmd.basic_io.sg_count = scb->sg_len;
 
 			if (scb->cmd.basic_io.lba)
-				scb->cmd.basic_io.lba =
-				    cpu_to_le32(le32_to_cpu
-						(scb->cmd.basic_io.lba) +
+				le32_add_cpu(&scb->cmd.basic_io.lba,
 						le16_to_cpu(scb->cmd.basic_io.
 							    sector_count));
 			else
-- 
1.5.3.7

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCHSET] [bl]e*_add_cpu conversions, , (Tue Feb 12, 7:06 pm)
Re: [PATCH] ufs: [bl]e*_add_cpu conversion, Roel Kluin, (Wed Feb 13, 5:41 am)
Re: [PATCH] ufs: [bl]e*_add_cpu conversion, Andrew Morton, (Sat Feb 16, 1:28 am)
Re: [PATCH] ufs: [bl]e*_add_cpu conversion, Roel Kluin, (Mon Feb 18, 7:22 pm)
Re: [PATCH] ufs: [bl]e*_add_cpu conversion, Marcin Slusarz, (Tue Feb 19, 1:45 pm)
Re: [PATCH] ufs: [bl]e*_add_cpu conversion, Evgeniy Dushistov, (Tue Feb 19, 3:16 pm)
Re: [PATCH] ufs: [bl]e*_add_cpu conversion, Marcin Slusarz, (Sun Mar 9, 6:21 am)
Re: [PATCH] ufs: [bl]e*_add_cpu conversion, Marcin Slusarz, (Wed Feb 13, 2:21 pm)
Re: [PATCH] sysv: [bl]e*_add_cpu conversion, Christoph Hellwig, (Thu Feb 14, 3:04 am)
Re: [PATCH] sysv: [bl]e*_add_cpu conversion, Christoph Hellwig, (Sat Feb 16, 9:31 am)
[PATCH] quota: le*_add_cpu conversion, , (Tue Feb 12, 7:06 pm)
Re: [PATCH] quota: le*_add_cpu conversion, Jan Kara, (Wed Feb 13, 5:52 am)
[PATCH] ocfs2: le*_add_cpu conversion, , (Tue Feb 12, 7:06 pm)
Re: [PATCH] ocfs2: le*_add_cpu conversion, Mark Fasheh, (Mon Feb 18, 5:03 pm)
[PATCH] ntfs: le*_add_cpu conversion, , (Tue Feb 12, 7:06 pm)
[PATCH] jfs: le*_add_cpu conversion, , (Tue Feb 12, 7:06 pm)
Re: [PATCH] jfs: le*_add_cpu conversion, Dave Kleikamp, (Wed Feb 13, 5:51 pm)
[PATCH] ext4: le*_add_cpu conversion, , (Tue Feb 12, 7:06 pm)
[PATCH] ext2: le*_add_cpu conversion, , (Tue Feb 12, 7:06 pm)
[PATCH] scsi: le*_add_cpu conversion, , (Tue Feb 12, 7:06 pm)
RE: [PATCH] scsi: le*_add_cpu conversion, Salyzyn, Mark, (Wed Feb 13, 10:06 am)
RE: [PATCH] ipw2200: le*_add_cpu conversion, Chatre, Reinette, (Wed Feb 13, 12:54 pm)
[PATCH] gfs2: be*_add_cpu conversion, , (Tue Feb 12, 7:06 pm)
Re: [PATCH] gfs2: be*_add_cpu conversion, Steven Whitehouse, (Wed Feb 13, 5:55 am)
[PATCH] affs: be*_add_cpu conversion, , (Tue Feb 12, 7:06 pm)
Re: [PATCH] infiniband: be*_add_cpu conversion, Roland Dreier, (Tue Feb 12, 8:32 pm)
Re: [PATCH] ieee 1394: be*_add_cpu conversion, Stefan Richter, (Sat Feb 16, 12:54 pm)
Re: [PATCH] crypto: be*_add_cpu conversion, Roel Kluin, (Wed Feb 13, 4:25 am)
Re: [PATCH] crypto: be*_add_cpu conversion, Marcin Slusarz, (Wed Feb 13, 2:36 pm)
Re: [PATCH] crypto: be*_add_cpu conversion, Herbert Xu, (Fri Mar 14, 4:24 am)