Re: [PATCH] [7/8] Implement true end_pfn_mapped for 32bit

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Thomas Gleixner <tglx@...>

To: Andi Kleen <ak@...>

Cc: <ying.huang@...>, <mingo@...>, <linux-kernel@...>

Subject: Re: [PATCH] [7/8] Implement true end_pfn_mapped for 32bit

Date: Tuesday, February 12, 2008 - 3:39 pm

On Mon, 11 Feb 2008, Andi Kleen wrote:
quoted text> Even on 32bit 2MB pages can map more memory than is in the true
> max_low_pfn if end_pfn is not highmem and not aligned to 2MB. 
> Add a end_pfn_map similar to x86-64 that accounts for this 
> fact. This is important for code that really needs to know about
> all mapping aliases. Needed for followup patches (in this case EFI)

It's not only necessary for followup patches, it is a question of
general correctness.

quoted text> @@ -36,7 +36,7 @@
>  #define max_pfn_mapped		end_pfn_map
>  #else
>  #include <asm/page_32.h>
> -#define max_pfn_mapped		max_low_pfn
> +#define max_pfn_mapped		end_pfn_map

We can nuke either max_pfn_mapped or end_pfn_map completely. I don't
care about which one, but keeping both makes no sense at all.

Thanks,

	tglx
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] [0/8] Various kernel mapping bug fixes, Andi Kleen, (Mon Feb 11, 5:34 am)

[PATCH] [8/8] RFC: Fix some EFI problems, Andi Kleen, (Mon Feb 11, 5:34 am)

Re: [PATCH] [8/8] RFC: Fix some EFI problems, Thomas Gleixner, (Tue Feb 12, 4:04 pm)

Re: [PATCH] [8/8] RFC: Fix some EFI problems, Andi Kleen, (Tue Feb 12, 4:23 pm)

Re: [PATCH] [8/8] RFC: Fix some EFI problems, Thomas Gleixner, (Tue Feb 12, 4:48 pm)

Re: [PATCH] [8/8] RFC: Fix some EFI problems, Andi Kleen, (Wed Feb 13, 7:05 am)

[PATCH] [7/8] Implement true end_pfn_mapped for 32bit, Andi Kleen, (Mon Feb 11, 5:34 am)

Re: [PATCH] [7/8] Implement true end_pfn_mapped for 32bit, Thomas Gleixner, (Tue Feb 12, 3:39 pm)

Re: [PATCH] [7/8] Implement true end_pfn_mapped for 32bit, Andi Kleen, (Tue Feb 12, 3:49 pm)

Re: [PATCH] [7/8] Implement true end_pfn_mapped for 32bit, Thomas Gleixner, (Tue Feb 12, 4:25 pm)

[PATCH] [6/8] Account overlapped mappings in end_pfn_map, Andi Kleen, (Mon Feb 11, 5:34 am)

Re: [PATCH] [6/8] Account overlapped mappings in end_pfn_map, Arjan van de Ven, (Mon Feb 11, 11:12 am)

Re: [PATCH] [6/8] Account overlapped mappings in end_pfn_map, Ingo Molnar, (Mon Feb 11, 9:08 am)

Re: [PATCH] [6/8] Account overlapped mappings in end_pfn_map, Andi Kleen, (Mon Feb 11, 9:27 am)

Re: [PATCH] [6/8] Account overlapped mappings in end_pfn_map, Peter Zijlstra, (Mon Feb 11, 10:16 am)

Re: [PATCH] [6/8] Account overlapped mappings in end_pfn_map, Andi Kleen, (Mon Feb 11, 10:24 am)

Re: [PATCH] [6/8] Account overlapped mappings in end_pfn_map, Sam Ravnborg, (Mon Feb 11, 10:41 am)

Re: [PATCH] [6/8] Account overlapped mappings in end_pfn_map, Ingo Molnar, (Mon Feb 11, 9:55 am)

[PATCH] [5/8] Fix logic error in 64bit memory hotadd, Andi Kleen, (Mon Feb 11, 5:34 am)

Re: [PATCH] [5/8] Fix logic error in 64bit memory hotadd, Ingo Molnar, (Mon Feb 11, 8:46 am)

Re: [PATCH] [5/8] Fix logic error in 64bit memory hotadd, Andi Kleen, (Mon Feb 11, 9:05 am)

Re: [PATCH] [5/8] Fix logic error in 64bit memory hotadd, Yasunori Goto, (Tue Feb 12, 6:35 am)

Re: [PATCH] [5/8] Fix logic error in 64bit memory hotadd, Andi Kleen, (Tue Feb 12, 7:20 am)

Re: [PATCH] [5/8] Fix logic error in 64bit memory hotadd, Ingo Molnar, (Mon Feb 11, 9:33 am)

Re: [PATCH] [5/8] Fix logic error in 64bit memory hotadd, Andi Kleen, (Mon Feb 11, 9:44 am)

[PATCH] [3/8] CPA: Test the correct mapping alias on x86-64, Andi Kleen, (Mon Feb 11, 5:34 am)

Re: [PATCH] [3/8] CPA: Test the correct mapping alias on x86..., Ingo Molnar, (Mon Feb 11, 7:49 am)

[PATCH] [4/8] CPA: Fix set_memory_x for ioremap, Andi Kleen, (Mon Feb 11, 5:34 am)

Re: [PATCH] [4/8] CPA: Fix set_memory_x for ioremap, Ingo Molnar, (Mon Feb 11, 8:27 am)

Re: [PATCH] [4/8] CPA: Fix set_memory_x for ioremap, Andi Kleen, (Mon Feb 11, 8:45 am)

[PATCH] [2/8] CPA: Flush the caches when setting pages not p..., Andi Kleen, (Mon Feb 11, 5:34 am)

Re: [PATCH] [2/8] CPA: Flush the caches when setting pages n..., Ingo Molnar, (Mon Feb 11, 7:00 am)

Re: [PATCH] [2/8] CPA: Flush the caches when setting pages n..., Andi Kleen, (Mon Feb 11, 8:26 am)

[PATCH] [1/8] CPA: Fix gbpages support in try_preserve_lage_..., Andi Kleen, (Mon Feb 11, 5:34 am)

Re: [PATCH] [1/8] CPA: Fix gbpages support in try_preserve_l..., Thomas Gleixner, (Mon Feb 11, 5:45 am)

Re: [PATCH] [1/8] CPA: Fix gbpages support in try_preserve_l..., Ingo Molnar, (Mon Feb 11, 6:12 am)

Re: [PATCH] [1/8] CPA: Fix gbpages support in try_preserve_l..., Andi Kleen, (Mon Feb 11, 7:01 am)

Navigation

Popular discussions


linux-kernel:
Christoph Lameter	Re: [RFC 00/15] x86_64: Optimize percpu accesses
Linus Torvalds	Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in
Greg Kroah-Hartman	[PATCH 005/196] Chinese: add translation of SubmittingDrivers
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
git:

openbsd-misc:

linux-netdev:
David Miller	[GIT]: Networking
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Christoph Hellwig	Re: [PATCH 06/32] IGET: Mark iget() and read_inode() as being obsolete [try #2]
Gerrit Renker	[PATCH 26/37] dccp: Integration of dynamic feature activation - part 1 (socket set...

Colocation donated by:

Online users

Syndicate