Re: [PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Linus Torvalds <torvalds@...>

Cc: Ingo Molnar <mingo@...>, Len Brown <lenb@...>, Andrew Morton <akpm@...>, <linux-acpi@...>, <linux-kernel@...>, <linux-pm@...>

Subject: Re: [PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled

Date: Tuesday, February 12, 2008 - 3:28 pm

On Tuesday 12 February 2008 04:41:42 Linus Torvalds wrote:
quoted text> 
> On Mon, 11 Feb 2008, Carlos Corbacho wrote:
> > 
> > WMI drivers, like their ACPI counterparts, should also check if ACPI is
> > disabled or not, and bail out if so, otherwise we cause a crash.
> 
> Shouldn't "wmi_has_guid()" just return false if ACPI isn't enabled, and 
> the drivers should just then always give up?

Yes - that's a better fix.

-Carlos
-- 
E-Mail: carlos@strangeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[GIT PATCH] ACPI patches for 2.6.25-rc0 (#2), Len Brown, (Fri Feb 8, 2:45 am)

Re: [GIT PATCH] ACPI patches for 2.6.25-rc0 (#2), Ingo Molnar, (Sat Feb 9, 2:17 am)

Re: [GIT PATCH] ACPI patches for 2.6.25-rc0 (#2), Ingo Molnar, (Sat Feb 9, 2:19 am)

Re: [GIT PATCH] ACPI patches for 2.6.25-rc0 (#2), Carlos Corbacho, (Sat Feb 9, 7:42 am)

Re: [GIT PATCH] ACPI patches for 2.6.25-rc0 (#2), Ingo Molnar, (Mon Feb 11, 5:17 am)

Re: [GIT PATCH] ACPI patches for 2.6.25-rc0 (#2), Carlos Corbacho, (Mon Feb 11, 3:23 pm)

[PATCH 2/2] tc1100-wmi - Fail gracefully if ACPI is disabled, Carlos Corbacho, (Mon Feb 11, 3:55 pm)

Re: [PATCH 2/2] tc1100-wmi - Fail gracefully if ACPI is dis..., Len Brown, (Thu Feb 14, 2:11 am)

Re: [PATCH 2/2] tc1100-wmi - Fail gracefully if ACPI is dis..., Len Brown, (Thu Feb 14, 2:15 am)

[PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled, Carlos Corbacho, (Mon Feb 11, 3:55 pm)

Re: [PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled, Linus Torvalds, (Tue Feb 12, 12:41 am)

Re: [PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled, Carlos Corbacho, (Tue Feb 12, 3:28 pm)

Re: [PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled, Ingo Molnar, (Tue Feb 12, 11:12 am)


linux-kernel:
Linus Torvalds	Linux 2.6.21-rc4
Jens Axboe	[PATCH 0/8] IO queuing and complete affinity
Nicholas A. Bellinger	Re: Integration of SCST in the mainstream Linux kernel
Robin Lee Powell	NFS hang + umount -f: better behaviour requested.
git:

linux-netdev:
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Ingo Molnar	Re: [crash] BUG: unable to handle kernel NULL pointer dereference at 0000000000000...
Gerrit Renker	[PATCH 19/37] dccp: Header option insertion routine for feature-negotiation
Gary Thomas	Marvell 88E609x switch?
linux-fsdevel:
Jamie Lokier	Re: silent semantic changes with reiser4
Jan Kara	[PATCH 10/16] ext4: Remove syncing logic from ext4_file_write
Jack Stone	Re: Versioning file system
Jens Axboe	[PATCH 8/8] vm: Add an tuning knob for vm.max_writeback_pages

Re: [PATCH 1/2] acer-wmi - Fail gracefully if ACPI is disabled

Online users