Home » Mailing list archives » linux-kernel » 2008 » February » 12

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Dave Hansen <haveblue@...>
To: Jan-Bernd Themann <ossthema@...>
Cc: linux-kernel <linux-kernel@...>, netdev <netdev@...>, linux-ppc <linuxppc-dev@...>, Thomas Klein <osstklei@...>, Themann, Jan-Bernd <themann@...>, Greg KH <greg@...>, Christoph Raisch <RAISCH@...>
Subject: Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier
Date: Tuesday, February 12, 2008 - 2:04 pm

On Mon, 2008-02-11 at 17:24 +0100, Jan-Bernd Themann wrote:

This driver is broken pretty horribly.  It won't even compile for a
plain ppc64 kernel:

http://sr71.net/~dave/linux/ehea-is-broken.config

I know it's used for very specific hardware, but this is the symptom of
it not using the proper abstracted interfaces to the VM.

In file included from /home/dave/work/linux/2.6/23/linux-2.6.git/drivers/net/ehea/ehea_main.c:42:
/home/dave/work/linux/2.6/23/linux-2.6.git/drivers/net/ehea/ehea_qmr.h:44:14: warning: "SECTION_SIZE_BITS" is not defined
/home/dave/work/linux/2.6/23/linux-2.6.git/drivers/net/ehea/ehea_qmr.h:45:2: error: #error eHEA module cannot work if kernel sectionsize < ehea sectionsize
  CC      drivers/net/mii.o
make[4]: *** [drivers/net/ehea/ehea_main.o] Error 1
make[4]: *** Waiting for unfinished jobs....
  CC      drivers/net/ixgb/ixgb_param.o
In file included from /home/dave/work/linux/2.6/23/linux-2.6.git/drivers/net/ehea/ehea_qmr.c:32:
/home/dave/work/linux/2.6/23/linux-2.6.git/drivers/net/ehea/ehea_qmr.h:44:14: warning: "SECTION_SIZE_BITS" is not defined
/home/dave/work/linux/2.6/23/linux-2.6.git/drivers/net/ehea/ehea_qmr.h:45:2: error: #error eHEA module cannot work if kernel sectionsize < ehea sectionsize
/home/dave/work/linux/2.6/23/linux-2.6.git/drivers/net/ehea/ehea_qmr.c: In function 'ehea_create_busmap':
/home/dave/work/linux/2.6/23/linux-2.6.git/drivers/net/ehea/ehea_qmr.c:574: error: 'NR_MEM_SECTIONS' undeclared (first use in this function)
/home/dave/work/linux/2.6/23/linux-2.6.git/drivers/net/ehea/ehea_qmr.c:574: error: (Each undeclared identifier is reported only once
/home/dave/work/linux/2.6/23/linux-2.6.git/drivers/net/ehea/ehea_qmr.c:574: error: for each function it appears in.)
/home/dave/work/linux/2.6/23/linux-2.6.git/drivers/net/ehea/ehea_qmr.c:575: error: implicit declaration of function 'valid_section_nr'
/home/dave/work/linux/2.6/23/linux-2.6.git/drivers/net/ehea/ehea_qmr.c: In function 'ehea_map_vaddr':
/home/dave/work/linux/2.6/23/linux-2.6.git/drivers/net/ehea/ehea_qmr.c:606: error: 'SECTION_SIZE_BITS' undeclared (first use in this function)
/home/dave/work/linux/2.6/23/linux-2.6.git/drivers/net/ehea/ehea_qmr.c: In function 'ehea_reg_kernel_mr':
/home/dave/work/linux/2.6/23/linux-2.6.git/drivers/net/ehea/ehea_qmr.c:655: error: 'SECTION_SIZE_BITS' undeclared (first use in this function)

-- Dave

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] drivers/base: export gpl (un)register_memory_notifier, Jan-Bernd Themann, (Mon Feb 11, 12:24 pm)
Re: [PATCH] drivers/base: export gpl (un)register_memory_not..., Dave Hansen, (Tue Feb 12, 2:04 pm)
Re: [PATCH] drivers/base: export gpl (un)register_memory_not..., Dave Hansen, (Mon Feb 11, 12:50 pm)
Re: [PATCH] drivers/base: export gpl (un)register_memory_not..., Dave Hansen, (Mon Feb 11, 12:47 pm)
Re: [PATCH] drivers/base: export gpl (un)register_memory_not..., Jan-Bernd Themann, (Wed Feb 13, 11:17 am)
Re: [PATCH] drivers/base: export gpl (un)register_memory_not..., Christoph Raisch, (Thu Feb 14, 4:46 am)
Re: [PATCH] drivers/base: export gpl (un)register_memory_not..., Dave Hansen, (Thu Feb 14, 1:12 pm)
Re: [PATCH] drivers/base: export gpl (un)register_memory_not..., Christoph Raisch, (Fri Feb 15, 9:22 am)
Re: [PATCH] drivers/base: export gpl (un)register_memory_not..., Dave Hansen, (Fri Feb 15, 12:55 pm)
Re: [PATCH] drivers/base: export gpl (un)register_memory_not..., Jan-Bernd Themann, (Mon Feb 18, 6:00 am)
Re: [PATCH] drivers/base: export gpl (un)register_memory_not..., Dave Hansen, (Wed Feb 20, 2:14 pm)
Re: [PATCH] drivers/base: export gpl (un)register_memory_not..., Badari Pulavarty, (Thu Feb 14, 1:36 pm)
Re: [PATCH] drivers/base: export gpl (un)register_memory_not..., Dave Hansen, (Thu Feb 14, 1:38 pm)
Re: [PATCH] drivers/base: export gpl (un)register_memory_not..., Dave Hansen, (Wed Feb 13, 1:05 pm)