Re: [git pull] kgdb-light -v10

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jason Wessel
Date: Tuesday, February 12, 2008 - 9:21 am

Andi Kleen wrote:

It is more than a simple recursion check (which is already in the code)
because there are some conditions we can recover from.  I'd rather not
crash the system out if it can be recovered.

kgdb_reenter_check() has the "simple" recursion check with the
exception_level variable.

It also has several special checks against the breakpoint situation I
described before as well as trying to remove all the breakpoints.  
Ultimately if all those checks fails, it results in panic, because at
the end of the day that is all you can do if you re-enter the debugger
from the debugger (IE: you are toast).

I don't see any reason to change the code there unless it can be further
improved some way.  We want to fail loudly and verbosely when this kind
of thing happens so we can determine if it was the end user that caused
the problem or if there is a real defect.

Jason.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
kgdb in git-x86#mm review, Andi Kleen, (Sun Feb 10, 6:53 pm)
Re: kgdb in git-x86#mm review, Frank Ch. Eigler, (Mon Feb 11, 8:32 am)
Re: kgdb in git-x86#mm review, Mark Lord, (Mon Feb 11, 9:03 am)
Re: kgdb in git-x86#mm review, Andi Kleen, (Mon Feb 11, 9:11 am)
Re: [git pull] kgdb-light -v8,, Jan Kiszka, (Mon Feb 11, 9:41 am)
Re: [git pull] kgdb-light -v8,, Ingo Molnar, (Mon Feb 11, 9:54 am)
[git pull] kgdb-light -v9, Ingo Molnar, (Mon Feb 11, 4:03 pm)
Re: [git pull] kgdb-light -v9, Sam Ravnborg, (Tue Feb 12, 2:35 am)
Re: [git pull] kgdb-light -v9, Andi Kleen, (Tue Feb 12, 3:03 am)
Re: [git pull] kgdb-light -v9, Roland McGrath, (Tue Feb 12, 3:26 am)
Re: [git pull] kgdb-light -v9, Ingo Molnar, (Tue Feb 12, 3:34 am)
[git pull] kgdb-light -v10, Ingo Molnar, (Tue Feb 12, 4:27 am)
Re: [git pull] kgdb-light -v10, Andi Kleen, (Tue Feb 12, 5:19 am)
Re: [git pull] kgdb-light -v10, Ingo Molnar, (Tue Feb 12, 5:38 am)
Re: [git pull] kgdb-light -v10, Domenico Andreoli, (Tue Feb 12, 6:18 am)
Re: [git pull] kgdb-light -v10, Jason Wessel, (Tue Feb 12, 6:30 am)
Re: [git pull] kgdb-light -v10, Andi Kleen, (Tue Feb 12, 6:50 am)
Re: [git pull] kgdb-light -v10, Jason Wessel, (Tue Feb 12, 6:59 am)
Re: [git pull] kgdb-light -v10, Jason Wessel, (Tue Feb 12, 7:35 am)
Re: [git pull] kgdb-light -v10, Andi Kleen, (Tue Feb 12, 7:39 am)
Re: [git pull] kgdb-light -v10, Ingo Molnar, (Tue Feb 12, 8:16 am)
Re: [git pull] kgdb-light -v10, Ingo Molnar, (Tue Feb 12, 8:28 am)
Re: [git pull] kgdb-light -v10, Andi Kleen, (Tue Feb 12, 8:28 am)
Re: [git pull] kgdb-light -v10, Andi Kleen, (Tue Feb 12, 8:36 am)
Re: [git pull] kgdb-light -v10, Domenico Andreoli, (Tue Feb 12, 8:45 am)
Re: [git pull] kgdb-light -v10, Andi Kleen, (Tue Feb 12, 9:11 am)
Re: [git pull] kgdb-light -v10, Jason Wessel, (Tue Feb 12, 9:21 am)
Re: [git pull] kgdb-light -v10, Ingo Molnar, (Tue Feb 12, 9:24 am)
Re: [git pull] kgdb-light -v10, Linus Torvalds, (Tue Feb 12, 9:25 am)
Re: [git pull] kgdb-light -v10, Ingo Molnar, (Tue Feb 12, 9:42 am)
Re: [git pull] kgdb-light -v10, Linus Torvalds, (Tue Feb 12, 9:46 am)
Re: [git pull] kgdb-light -v10, Jason Wessel, (Tue Feb 12, 9:48 am)
Re: [git pull] kgdb-light -v10, Ingo Molnar, (Tue Feb 12, 10:01 am)
Re: [git pull] kgdb-light -v10, Andi Kleen, (Tue Feb 12, 10:01 am)
Re: [git pull] kgdb-light -v10, Andi Kleen, (Tue Feb 12, 10:07 am)
Re: [git pull] kgdb-light -v10, Ingo Molnar, (Tue Feb 12, 10:10 am)
Re: [git pull] kgdb-light -v10, Andi Kleen, (Tue Feb 12, 10:10 am)
Re: [git pull] kgdb-light -v10, Linus Torvalds, (Tue Feb 12, 11:11 am)
Re: [git pull] kgdb-light -v10, Andrew Morton, (Tue Feb 12, 11:20 am)
Re: [git pull] kgdb-light -v10, Andi Kleen, (Tue Feb 12, 11:20 am)
Re: [git pull] kgdb-light -v10, Linus Torvalds, (Tue Feb 12, 12:01 pm)
Re: [git pull] kgdb-light -v10, Andi Kleen, (Tue Feb 12, 12:16 pm)
Re: [git pull] kgdb-light -v10, Andi Kleen, (Tue Feb 12, 12:22 pm)
Re: [git pull] kgdb-light -v10, Frank Ch. Eigler, (Tue Feb 12, 12:34 pm)
Re: [git pull] kgdb-light -v10, Andi Kleen, (Tue Feb 12, 1:16 pm)
Re: [git pull] kgdb-light -v10, Ingo Molnar, (Tue Feb 12, 2:01 pm)
Re: [RFC][PATCH] modular kgdb-light, Jason Wessel, (Fri Feb 15, 1:24 pm)
Re: [git pull] kgdb-light -v10, Jason Wessel, (Fri Feb 15, 1:36 pm)