Re: REGRESSION: x86 vDSO: remove vdso-syms.o

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Ingo Molnar <mingo@...>
Cc: Priit Laes <plaes@...>, <linux-kernel@...>, Thomas Gleixner <tglx@...>, Sam Ravnborg <sam@...>
Date: Monday, February 11, 2008 - 7:23 pm

> if that file is empty, it might be the effect of a Ctrl-C. I sometimes 

It is the known situation with the compiler since the dawn of time, yes.
It just writes the file directly, so if it dies in the middle, there's a
file with a fresh date.  For things like this done in makefile commands
with >, it has forever been canonical for the anal to use:

	... > $@.new
	mv -f $@.new $@

which avoids the problem.  The kernel makefiles are entirely haphazard
about places that do this or don't.  It uglifies the commands, but avoids
the problem of freshly-dated but wrong/empty files from botched make runs.
I did not do this in cmd_vdsosym (though I did in cmd_vdso32sym, go figure).


Thanks,
Roland
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
REGRESSION: x86 vDSO: remove vdso-syms.o, Priit Laes, (Mon Feb 11, 6:30 pm)
Re: REGRESSION: x86 vDSO: remove vdso-syms.o, Roland McGrath, (Mon Feb 11, 6:53 pm)
Re: REGRESSION: x86 vDSO: remove vdso-syms.o, Priit Laes, (Mon Feb 11, 8:00 pm)
Re: REGRESSION: x86 vDSO: remove vdso-syms.o, Roland McGrath, (Mon Feb 11, 8:36 pm)
Re: REGRESSION: x86 vDSO: remove vdso-syms.o, Ingo Molnar, (Mon Feb 11, 7:16 pm)
Re: REGRESSION: x86 vDSO: remove vdso-syms.o, Roland McGrath, (Mon Feb 11, 7:23 pm)
Re: REGRESSION: x86 vDSO: remove vdso-syms.o, Roland McGrath, (Mon Feb 11, 7:29 pm)
Re: REGRESSION: x86 vDSO: remove vdso-syms.o, Jan Engelhardt, (Fri Feb 15, 9:45 am)