Home » Mailing list archives » linux-kernel » 2008 » February » 11

Re: [PATCH] [1/5] Only do century BCD conversion when we know the RTC is BCD

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen <andi@...>
To: Thomas Gleixner <tglx@...>
Cc: Andi Kleen <ak@...>, <mingo@...>, <linux-kernel@...>
Subject: Re: [PATCH] [1/5] Only do century BCD conversion when we know the RTC is BCD
Date: Monday, February 11, 2008 - 6:15 pm

> So the warning comes a bit late :)

I suspect if this was wrong before it would not have been noticed
because user space hwclock would work around it. The warning
certainly won't hurt.

Anyways if you feel strongly about this (I don't) then drop
this patch, but apply the other ones in the series. The main
one I consider important is the change to the 2000 offset for 32bit
to extend the 32bit lifetime.

-Andi
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] [1/5] Only do century BCD conversion when we know th..., Andi Kleen, (Sat Feb 9, 11:16 am)
Re: [PATCH] [1/5] Only do century BCD conversion when we kno..., Thomas Gleixner, (Mon Feb 11, 4:30 am)
Re: [PATCH] [1/5] Only do century BCD conversion when we kno..., Andi Kleen, (Mon Feb 11, 4:56 am)
Re: [PATCH] [1/5] Only do century BCD conversion when we kno..., Thomas Gleixner, (Mon Feb 11, 6:08 pm)
Re: [PATCH] [1/5] Only do century BCD conversion when we kno..., Andi Kleen, (Mon Feb 11, 6:15 pm)
Re: [PATCH] [1/5] Only do century BCD conversion when we kno..., Thomas Gleixner, (Tue Feb 12, 4:36 pm)
Re: [PATCH] [1/5] Only do century BCD conversion when we kno..., Andi Kleen, (Wed Feb 13, 9:49 am)
[PATCH] [5/5] Enable ACPI extended century handling for 32bi..., Andi Kleen, (Sat Feb 9, 11:17 am)
Re: [PATCH] [5/5] Enable ACPI extended century handling for ..., Thomas Gleixner, (Sat Feb 16, 3:38 pm)
[PATCH] [4/5] Fix wrong comment, Andi Kleen, (Sat Feb 9, 11:17 am)
[PATCH] [3/5] Add warning when RTC clock reports binary , Andi Kleen, (Sat Feb 9, 11:16 am)
Re: [PATCH] [3/5] Add warning when RTC clock reports binary , Thomas Gleixner, (Sat Feb 16, 3:38 pm)
[PATCH] [2/5] Use 2000 offset for 32bit kernels, Andi Kleen, (Sat Feb 9, 11:16 am)
Re: [PATCH] [2/5] Use 2000 offset for 32bit kernels, Thomas Gleixner, (Sat Feb 16, 3:24 pm)
Re: [PATCH] [2/5] Use 2000 offset for 32bit kernels, Thomas Gleixner, (Wed Feb 20, 6:07 am)
Re: [PATCH] [2/5] Use 2000 offset for 32bit kernels, Andi Kleen, (Wed Feb 20, 6:23 am)