Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: John David Anglin

Subject: Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent

Date: Monday, February 11, 2008 - 10:08 am

> James Bottomley wrote:
quoted text> > On Mon, 2008-02-11 at 17:23 +0100, Roel Kluin wrote:
> >> duplicate pa11_dma_alloc_consistent; more appropriate appears
> >> pa11_dma_alloc_noncoherent here. 
> >>
> >> Not tested, please confirm that this fix is correct
> > 
> > No, it looks completely incorrect to me.  What makes you think a pcxl
> > box has a problem with coherency?
> 
> Ok, please ignore the patch then. It just appeared suspicious to me
> that the function did exist, but the names assigned were different.

How about a comment?

Dave
-- 
J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_ ..., Roel Kluin, (Mon Feb 11, 9:23 am)

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.al ..., Matthew Wilcox, (Mon Feb 11, 9:42 am)

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.al ..., James Bottomley, (Mon Feb 11, 9:45 am)

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.al ..., Roel Kluin, (Mon Feb 11, 9:45 am)

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.al ..., James Bottomley, (Mon Feb 11, 9:55 am)

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.al ..., Roel Kluin, (Mon Feb 11, 9:57 am)

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_o ..., John David Anglin, (Mon Feb 11, 10:08 am)

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_o ..., Roel Kluin, (Mon Feb 11, 11:56 am)

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.al ..., Kyle McMartin, (Mon Feb 11, 11:58 am)

Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.al ..., Kyle McMartin, (Mon Feb 11, 12:10 pm)


linux-kernel:
Russell King	Re: ARM defconfig files
Jesse Barnes	Re: PCI MSI breaks when booting with nosmp
James Morris	Re: [AppArmor 01/41] Pass struct vfsmount to the inode_create LSM hook
Philip Langdale	[PATCH 2.6.19] mmc: Add support for SDHC cards (Take 4)
Oren Laadan	[PATCH v21 073/100] c/r: Add AF_UNIX support (v12)
git:
Felipe Contreras	Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins
Paolo Ciarrocchi	Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins
Johannes Schindelin	[PATCH] fetch: refuse to fetch into the current branch in a non-bare repository
Johannes Schindelin	Re: [PATCH] Fix install-doc-quick target
Peter Oberndorfer	Subject: [PATCH] fix stg edit command
linux-netdev:
Ursula Braun	[patch 2/8] [PATCH] af_iucv: sync sk shutdown flag if iucv path is quiesced
Andi Kleen	Re: RFC: Nagle latency tuning
David Miller	Re: [RFC 0/5] generic rx recycling
Gary Thomas	Re: Marvell 88E609x switch?
Chuck Lever	Re: [RFC] ipv6: Change %pI6 format to output compacted addresses?
git-commits-head:
Linux Kernel Mailing List	New device ID for sc92031 [1088:2031]
Linux Kernel Mailing List	e1000e: Expose MDI-X status via ethtool change
Linux Kernel Mailing List	arm/imx/gpio: GPIO_INT_{HIGH,LOW}_LEV are not necessarily constant
Linux Kernel Mailing List	powerpc/kexec: Add support for FSL-BookE
Linux Kernel Mailing List	trivial: fix comment typo in fs/compat.c
openbsd-misc:
Theo de Raadt	Re: RES: OpenBSD on IBM System X3550 7879
Bret S. Lambert	Re: any web management gui for pf ?
Rob Shepherd	x86 hardware for router system
Flickr Photo Map for iPad and iPhone	Thanks for the Great Launch of Flickr Photo Map for iPad + iPhone
Nick Holland	Re: Install OpenBSD from USB ?