Re: [PATCH 6/9] firewire: fw-sbp2: don't add scsi_device twice | KernelTrap

Re: [PATCH 6/9] firewire: fw-sbp2: don't add scsi_device twice

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Jarod Wilson <jwilson@...>

To: Stefan Richter <stefanr@...>

Cc: <linux1394-devel@...>, <linux-kernel@...>

Subject: Re: [PATCH 6/9] firewire: fw-sbp2: don't add scsi_device twice

Date: Monday, February 11, 2008 - 1:19 pm

Stefan Richter wrote:
quoted text> When a reconnect failed but re-login succeeded, __scsi_add_device was
> called again.
> 
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Was the spurious __scsi_add_device simply failing, or was it causing 
other problems as well? I can't remember if I've hit that or not. In 
either case, not calling it when we know we don't need to makes sense.

Signed-off-by: Jarod Wilson <jwilson@redhat.com>


-- 
Jarod Wilson
jwilson@redhat.com

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/9] firewire-sbp2: misc hotplug related patches, Stefan Richter, (Sun Feb 3, 6:00 pm)

[PATCH 10/9] firewire: fw-sbp2: preemptively block sdev, Stefan Richter, (Wed Feb 6, 5:07 pm)

Re: [PATCH 0/9] firewire-sbp2: misc hotplug related patches, Jarod Wilson, (Wed Feb 6, 1:17 am)

Re: [PATCH 0/9] firewire-sbp2: misc hotplug related patches, Stefan Richter, (Wed Feb 6, 2:27 pm)

[PATCH 11/9] firewire: fw-sbp2: enforce a retry of __scsi_ad..., Stefan Richter, (Wed Feb 6, 5:09 pm)

Re: [PATCH 11/9] firewire: fw-sbp2: enforce a retry of __scs..., Jarod Wilson, (Fri Feb 8, 2:54 pm)

Re: [PATCH 11/9] firewire: fw-sbp2: enforce a retry of __scs..., Stefan Richter, (Fri Feb 8, 3:58 pm)

[PATCH 11/9 update] firewire: fw-sbp2: enforce a retry of __..., Stefan Richter, (Fri Feb 8, 5:33 pm)

Re: [PATCH 11/9 update] firewire: fw-sbp2: enforce a retry o..., Jarod Wilson, (Sun Feb 10, 2:36 pm)

Re: [PATCH 11/9 update] firewire: fw-sbp2: enforce a retry o..., Stefan Richter, (Sat Feb 16, 11:01 am)

Re: [PATCH 0/9] firewire-sbp2: misc hotplug related patches, John Stoffel, (Mon Feb 4, 11:54 am)

Re: [PATCH 0/9] firewire-sbp2: misc hotplug related patches, Stefan Richter, (Mon Feb 4, 1:48 pm)

Re: [PATCH 0/9] firewire-sbp2: misc hotplug related patches, John Stoffel, (Mon Feb 4, 2:51 pm)

[PATCH 9/9] firewire: fw-sbp2: fix I/O errors during reconnect, Stefan Richter, (Sun Feb 3, 6:13 pm)

Re: [PATCH 9/9] firewire: fw-sbp2: fix I/O errors during rec..., Jarod Wilson, (Mon Feb 11, 2:09 pm)

Re: [PATCH 9/9] firewire: fw-sbp2: fix I/O errors during rec..., Stefan Richter, (Mon Feb 11, 4:21 pm)

Re: [PATCH 9/9] firewire: fw-sbp2: fix I/O errors during rec..., Stefan Richter, (Sat Feb 16, 11:37 am)

Re: [PATCH 9/9] firewire: fw-sbp2: fix I/O errors during rec..., Stefan Richter, (Sat Feb 16, 11:51 am)

Re: [PATCH 9/9] firewire: fw-sbp2: fix I/O errors during rec..., Jarod Wilson, (Tue Feb 12, 1:07 am)

Re: [PATCH 9/9] firewire: fw-sbp2: fix I/O errors during rec..., Stefan Richter, (Tue Feb 12, 4:01 am)

[PATCH 8/9] firewire: fw-sbp2: sort includes, Stefan Richter, (Sun Feb 3, 6:12 pm)

[PATCH 7/9] firewire: fw-sbp2: logout and login after failed..., Stefan Richter, (Sun Feb 3, 6:11 pm)

Re: [PATCH 7/9] firewire: fw-sbp2: logout and login after fa..., Jarod Wilson, (Mon Feb 11, 1:32 pm)

[PATCH 6/9] firewire: fw-sbp2: don't add scsi_device twice, Stefan Richter, (Sun Feb 3, 6:10 pm)

Re: [PATCH 6/9] firewire: fw-sbp2: don't add scsi_device twice, Jarod Wilson, (Mon Feb 11, 1:19 pm)

Re: [PATCH 6/9] firewire: fw-sbp2: don't add scsi_device twice, Stefan Richter, (Mon Feb 11, 3:42 pm)

Re: [PATCH 6/9] firewire: fw-sbp2: don't add scsi_device twice, Stefan Richter, (Tue Feb 12, 4:55 am)

[PATCH 5/9] firewire: fw-sbp2: log bus_id at management requ..., Stefan Richter, (Sun Feb 3, 6:09 pm)

Re: [PATCH 5/9] firewire: fw-sbp2: log bus_id at management ..., Jarod Wilson, (Mon Feb 11, 1:16 pm)

[PATCH 4/9] firewire: fw-sbp2: wait for completion of fetch ..., Stefan Richter, (Sun Feb 3, 6:08 pm)

Re: [PATCH 4/9] firewire: fw-sbp2: wait for completion of fe..., Stefan Richter, (Mon Feb 4, 4:11 am)

[PATCH 3/9] ieee1394: sbp2: add INQUIRY delay workaround, Stefan Richter, (Sun Feb 3, 6:07 pm)

Re: [PATCH 3/9] ieee1394: sbp2: add INQUIRY delay workaround, Jarod Wilson, (Mon Feb 11, 1:03 pm)

[PATCH 2/9] firewire: fw-sbp2: add INQUIRY delay workaround, Stefan Richter, (Sun Feb 3, 6:04 pm)

Re: [PATCH 2/9] firewire: fw-sbp2: add INQUIRY delay workaro..., Jarod Wilson, (Mon Feb 11, 1:01 pm)

[PATCH 1/9] firewire: log GUID of new devices, Stefan Richter, (Sun Feb 3, 6:03 pm)

Re: [PATCH 1/9] firewire: log GUID of new devices, Jarod Wilson, (Mon Feb 11, 12:53 pm)

Re: [PATCH 1/9] firewire: log GUID of new devices, Stefan Richter, (Mon Feb 4, 4:14 am)

Navigation

Popular discussions


linux-kernel:
Glauber de Oliveira Costa	[PATCH 08/79] [PATCH] use identify_boot_cpu
David Woodhouse	[PATCH v2] Stop pmac_zilog from abusing 8250's device numbers.
Greg Kroah-Hartman	[PATCH 002/196] Chinese: rephrase English introduction in HOWTO
Jeremy Fitzhardinge	[PATCH 30 of 31] xen: no need for domU to worry about MCE/MCA
git:

openbsd-misc:

linux-netdev:
Gerrit Renker	[PATCH 03/37] dccp: List management for new feature negotiation
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).

Colocation donated by:

Who's online

There are currently 9 users and 1081 guests online.

Online users

Syndicate